Browse Source

remove synchronization in addReference since getReferences hands out an un-synchronized table anyway

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@669416 13f79535-47bb-0310-9956-ffa450edef68
master
Stefan Bodewig 17 years ago
parent
commit
e03db74846
1 changed files with 10 additions and 12 deletions
  1. +10
    -12
      src/main/org/apache/tools/ant/Project.java

+ 10
- 12
src/main/org/apache/tools/ant/Project.java View File

@@ -1904,19 +1904,17 @@ public class Project implements ResourceFactory {
* @param value The value of the reference.
*/
public void addReference(String referenceName, Object value) {
synchronized (references) {
Object old = ((AntRefTable) references).getReal(referenceName);
if (old == value) {
// no warning, this is not changing anything
return;
}
if (old != null && !(old instanceof UnknownElement)) {
log("Overriding previous definition of reference to " + referenceName,
MSG_VERBOSE);
}
log("Adding reference: " + referenceName, MSG_DEBUG);
references.put(referenceName, value);
Object old = ((AntRefTable) references).getReal(referenceName);
if (old == value) {
// no warning, this is not changing anything
return;
}
if (old != null && !(old instanceof UnknownElement)) {
log("Overriding previous definition of reference to " + referenceName,
MSG_VERBOSE);
}
log("Adding reference: " + referenceName, MSG_DEBUG);
references.put(referenceName, value);
}

/**


Loading…
Cancel
Save