From e03db74846d20974a3aae9cd7054948e5cd502cf Mon Sep 17 00:00:00 2001
From: Stefan Bodewig <bodewig@apache.org>
Date: Thu, 19 Jun 2008 08:09:39 +0000
Subject: [PATCH] remove synchronization in addReference since getReferences
 hands out an un-synchronized table anyway

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@669416 13f79535-47bb-0310-9956-ffa450edef68
---
 src/main/org/apache/tools/ant/Project.java | 22 ++++++++++------------
 1 file changed, 10 insertions(+), 12 deletions(-)

diff --git a/src/main/org/apache/tools/ant/Project.java b/src/main/org/apache/tools/ant/Project.java
index 2d7ff60ea..c45d29e92 100644
--- a/src/main/org/apache/tools/ant/Project.java
+++ b/src/main/org/apache/tools/ant/Project.java
@@ -1904,19 +1904,17 @@ public class Project implements ResourceFactory {
      * @param value The value of the reference.
      */
     public void addReference(String referenceName, Object value) {
-        synchronized (references) {
-            Object old = ((AntRefTable) references).getReal(referenceName);
-            if (old == value) {
-                // no warning, this is not changing anything
-                return;
-            }
-            if (old != null && !(old instanceof UnknownElement)) {
-                log("Overriding previous definition of reference to " + referenceName,
-                    MSG_VERBOSE);
-            }
-            log("Adding reference: " + referenceName, MSG_DEBUG);
-            references.put(referenceName, value);
+        Object old = ((AntRefTable) references).getReal(referenceName);
+        if (old == value) {
+            // no warning, this is not changing anything
+            return;
+        }
+        if (old != null && !(old instanceof UnknownElement)) {
+            log("Overriding previous definition of reference to " + referenceName,
+                MSG_VERBOSE);
         }
+        log("Adding reference: " + referenceName, MSG_DEBUG);
+        references.put(referenceName, value);
     }
 
     /**