add lock in encryption; #32

shadowsocks-csharp/Controller/Local.cs

@@ -189,8 +189,8 @@ namespace Shadowsocks.Controller
                 // Complete the connection.
                 remote.EndConnect(ar);
 
-                Console.WriteLine("Socket connected to {0}",
-                    remote.RemoteEndPoint.ToString());
+                //Console.WriteLine("Socket connected to {0}",
+                //    remote.RemoteEndPoint.ToString());
 
                 handshakeReceive();
             }
@@ -348,7 +348,6 @@ namespace Shadowsocks.Controller
                 }
                 else
                 {
-                    Console.WriteLine("bytesRead: " + bytesRead.ToString());
                     this.Close();
                 }
             }

shadowsocks-csharp/Encrypt/PolarSSLEncryptor.cs

@@ -3,6 +3,7 @@ using System.Collections.Generic;
 using System.Runtime.InteropServices;
 using System.Security.Cryptography;
 using System.Text;
+using System.Threading;
 
 namespace Shadowsocks.Encrypt
 {
@@ -166,20 +167,24 @@ namespace Shadowsocks.Encrypt
                 randBytes(outbuf, ivLen);
                 InitCipher(ref _encryptCtx, outbuf, true);
                 outlength = length + ivLen;
-                switch (_cipher)
+                lock (tempbuf)
                 {
-                    case CIPHER_AES:
-                        PolarSSL.aes_crypt_cfb128(_encryptCtx, PolarSSL.AES_ENCRYPT, length, ref _encryptIVOffset, _encryptIV, buf, tempbuf);
-                        break;
-                    case CIPHER_BF:
-                        PolarSSL.blowfish_crypt_cfb64(_encryptCtx, PolarSSL.BLOWFISH_ENCRYPT, length, ref _encryptIVOffset, _encryptIV, buf, tempbuf);
-                        break;
-                    case CIPHER_RC4:
-                        PolarSSL.arc4_crypt(_encryptCtx, length, buf, tempbuf);
-                        break;
+                    // C# could be multi-threaded
+                    switch (_cipher)
+                    {
+                        case CIPHER_AES:
+                            PolarSSL.aes_crypt_cfb128(_encryptCtx, PolarSSL.AES_ENCRYPT, length, ref _encryptIVOffset, _encryptIV, buf, tempbuf);
+                            break;
+                        case CIPHER_BF:
+                            PolarSSL.blowfish_crypt_cfb64(_encryptCtx, PolarSSL.BLOWFISH_ENCRYPT, length, ref _encryptIVOffset, _encryptIV, buf, tempbuf);
+                            break;
+                        case CIPHER_RC4:
+                            PolarSSL.arc4_crypt(_encryptCtx, length, buf, tempbuf);
+                            break;
+                    }
+                    outlength = length + ivLen;
+                    Buffer.BlockCopy(tempbuf, 0, outbuf, ivLen, outlength);
                 }
-                outlength = length + ivLen;
-                Buffer.BlockCopy(tempbuf, 0, outbuf, ivLen, outlength);
             }
             else
             {
@@ -205,18 +210,22 @@ namespace Shadowsocks.Encrypt
             {
                 InitCipher(ref _decryptCtx, buf, false);
                 outlength = length - ivLen;
-                Buffer.BlockCopy(buf, ivLen, tempbuf, 0, length - ivLen);
-                switch (_cipher)
+                lock (tempbuf)
                 {
-                    case CIPHER_AES:
-                        PolarSSL.aes_crypt_cfb128(_decryptCtx, PolarSSL.AES_DECRYPT, length - ivLen, ref _decryptIVOffset, _decryptIV, tempbuf, outbuf);
-                        break;
-                    case CIPHER_BF:
-                        PolarSSL.blowfish_crypt_cfb64(_decryptCtx, PolarSSL.BLOWFISH_DECRYPT, length - ivLen, ref _decryptIVOffset, _decryptIV, tempbuf, outbuf);
-                        break;
-                    case CIPHER_RC4:
-                        PolarSSL.arc4_crypt(_decryptCtx, length - ivLen, tempbuf, outbuf);
-                        break;
+                    // C# could be multi-threaded
+                    Buffer.BlockCopy(buf, ivLen, tempbuf, 0, length - ivLen);
+                    switch (_cipher)
+                    {
+                        case CIPHER_AES:
+                            PolarSSL.aes_crypt_cfb128(_decryptCtx, PolarSSL.AES_DECRYPT, length - ivLen, ref _decryptIVOffset, _decryptIV, tempbuf, outbuf);
+                            break;
+                        case CIPHER_BF:
+                            PolarSSL.blowfish_crypt_cfb64(_decryptCtx, PolarSSL.BLOWFISH_DECRYPT, length - ivLen, ref _decryptIVOffset, _decryptIV, tempbuf, outbuf);
+                            break;
+                        case CIPHER_RC4:
+                            PolarSSL.arc4_crypt(_decryptCtx, length - ivLen, tempbuf, outbuf);
+                            break;
+                    }
                 }
             }
             else