diff --git a/src/etc/testcases/taskdefs/optional/replaceregexp.xml b/src/etc/testcases/taskdefs/optional/replaceregexp.xml index 2c61475c5..cb7130a53 100644 --- a/src/etc/testcases/taskdefs/optional/replaceregexp.xml +++ b/src/etc/testcases/taskdefs/optional/replaceregexp.xml @@ -8,6 +8,10 @@ + + + + @@ -15,6 +19,20 @@ + + + + + + + + + + + + + + diff --git a/src/etc/testcases/taskdefs/optional/replaceregexp2.properties b/src/etc/testcases/taskdefs/optional/replaceregexp2.properties new file mode 100644 index 000000000..e0c2a4807 --- /dev/null +++ b/src/etc/testcases/taskdefs/optional/replaceregexp2.properties @@ -0,0 +1 @@ +OldAbc=Def \ No newline at end of file diff --git a/src/etc/testcases/taskdefs/optional/replaceregexp2.result.properties b/src/etc/testcases/taskdefs/optional/replaceregexp2.result.properties new file mode 100644 index 000000000..9a469c785 --- /dev/null +++ b/src/etc/testcases/taskdefs/optional/replaceregexp2.result.properties @@ -0,0 +1 @@ +NewProp=AbcDef \ No newline at end of file diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/ReplaceRegExp.java b/src/main/org/apache/tools/ant/taskdefs/optional/ReplaceRegExp.java index 0bd67b380..bfcf81c65 100644 --- a/src/main/org/apache/tools/ant/taskdefs/optional/ReplaceRegExp.java +++ b/src/main/org/apache/tools/ant/taskdefs/optional/ReplaceRegExp.java @@ -354,7 +354,7 @@ public class ReplaceRegExp extends Task { changes = true; } - pw.println(res); + pw.print(res); pw.flush(); } diff --git a/src/testcases/org/apache/tools/ant/taskdefs/optional/ReplaceRegExpTest.java b/src/testcases/org/apache/tools/ant/taskdefs/optional/ReplaceRegExpTest.java index a46c5d272..101bac3f8 100644 --- a/src/testcases/org/apache/tools/ant/taskdefs/optional/ReplaceRegExpTest.java +++ b/src/testcases/org/apache/tools/ant/taskdefs/optional/ReplaceRegExpTest.java @@ -1,7 +1,7 @@ /* * The Apache Software License, Version 1.1 * - * Copyright (c) 2001 The Apache Software Foundation. All rights + * Copyright (c) 2001-2002 The Apache Software Foundation. All rights * reserved. * * Redistribution and use in source and binary forms, with or without @@ -54,8 +54,10 @@ package org.apache.tools.ant.taskdefs.optional; import org.apache.tools.ant.BuildFileTest; +import org.apache.tools.ant.util.FileUtils; import java.util.Properties; +import java.io.File; import java.io.FileInputStream; import java.io.IOException; @@ -111,4 +113,26 @@ public class ReplaceRegExpTest extends BuildFileTest { assertEquals("AbcDef", after.get("NewProp")); } + public void testDontAddNewline1() throws IOException { + executeTarget("testDontAddNewline1"); + assertTrue("Files match", + FileUtils.newFileUtils() + .contentEquals(new File("src/etc/testcases/taskdefs/optional/test.properties"), + new File("src/etc/testcases/taskdefs/optional/replaceregexp2.result.properties"))); + } + + /** + * FIXME + * + * will be fixed this week, just running out of time and + * committing a partly fixed version now -- Stefan + public void testDontAddNewline2() throws IOException { + executeTarget("testDontAddNewline2"); + assertTrue("Files match", + FileUtils.newFileUtils() + .contentEquals(new File("src/etc/testcases/taskdefs/optional/test.properties"), + new File("src/etc/testcases/taskdefs/optional/replaceregexp2.result.properties"))); + } + */ + }// ReplaceRegExpTest