Ignore ZIP extra fields that don't contain the recommended header+length structure - this is what unzip does as well. PR 42940

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@739300 13f79535-47bb-0310-9956-ffa450edef68

WHATSNEW

@@ -670,6 +670,10 @@ Other changes:
    processor.
    Bugzilla Issue 46612.
 
+ * the ZIP library will now ignore ZIP extra fields that don't specify
+   a size.
+   Bugzilla Report 42940.
+
 Changes from Ant 1.7.0 TO Ant 1.7.1
 =============================================
 

src/main/org/apache/tools/zip/ExtraFieldUtils.java

@@ -117,10 +117,6 @@ public class ExtraFieldUtils {
             }
             start += (length + WORD);
         }
-        if (start != data.length) { // array not exhausted
-            throw new ZipException("data starting at " + start
-                + " is in unknown format");
-        }
 
         ZipExtraField[] result = new ZipExtraField[v.size()];
         return (ZipExtraField[]) v.toArray(result);

src/main/org/apache/tools/zip/ZipEntry.java

@@ -252,7 +252,7 @@ public class ZipEntry extends java.util.zip.ZipEntry implements Cloneable {
         try {
             setExtraFields(ExtraFieldUtils.parse(extra));
         } catch (Exception e) {
-            throw new RuntimeException(e.getMessage());
+            throw new RuntimeException(e.getMessage(), e);
         }
     }
 

src/main/org/apache/tools/zip/ZipExtraField.java

@@ -64,7 +64,7 @@ public interface ZipExtraField {
     byte[] getLocalFileDataData();
 
     /**
-     * The actual data to put central directory - without Header-ID or
+     * The actual data to put into central directory - without Header-ID or
      * length specifier.
      * @return the data
      * @since 1.1

src/tests/antunit/taskdefs/unzip-test.xml

@@ -44,6 +44,16 @@
     <au:assertFileExists file="${output}/foo/file"/>
   </target>
 
+  <target name="testTwoByteExtraFieldInLFH"
+          description="https://issues.apache.org/bugzilla/show_bug.cgi?id=42940"
+          >
+    <mkdir dir="${input}"/>
+    <mkdir dir="${output}"/>
+    <copy file="zip/Bugzilla-42940.zip" tofile="${input}/test.zip"/>
+    <unzip src="${input}/test.zip" dest="${output}"/>
+    <au:assertFileExists file="${output}/META-INF/MANIFEST.MF"/>
+  </target>
+
   <target name="testArchiveIsClosedForInvalidZips"
           description="https://issues.apache.org/bugzilla/show_bug.cgi?id=46559"
           >

src/tests/junit/org/apache/tools/zip/ExtraFieldUtilsTest.java

@@ -40,7 +40,7 @@ public class ExtraFieldUtilsTest extends TestCase implements UnixStat {
         a.setDirectory(true);
         dummy = new UnrecognizedExtraField();
         dummy.setHeaderId(new ZipShort(1));
-        dummy.setLocalFileDataData(new byte[0]);
+        dummy.setLocalFileDataData(new byte[] {0});
         dummy.setCentralDirectoryData(new byte[] {0});
 
         aLocal = a.getLocalFileDataData();
@@ -68,7 +68,7 @@ public class ExtraFieldUtilsTest extends TestCase implements UnixStat {
         assertEquals("mode field 1", 040755,
                      ((AsiExtraField) ze[0]).getMode());
         assertTrue("type field 2", ze[1] instanceof UnrecognizedExtraField);
-        assertEquals("data length field 2", 0,
+        assertEquals("data length field 2", 1,
                      ze[1].getLocalFileDataLength().getValue());
 
         byte[] data2 = new byte[data.length-1];