From ce63a87681d8d74e45a080dc28722cd7b188cb2a Mon Sep 17 00:00:00 2001 From: Peter Donald Date: Mon, 18 Feb 2002 08:39:58 +0000 Subject: [PATCH] Move complex operations outside loop body git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@271403 13f79535-47bb-0310-9956-ffa450edef68 --- .../interfaces/service/MultiSourceServiceManager.java | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/proposal/myrmidon/src/java/org/apache/myrmidon/interfaces/service/MultiSourceServiceManager.java b/proposal/myrmidon/src/java/org/apache/myrmidon/interfaces/service/MultiSourceServiceManager.java index 4b4f9d431..042463400 100644 --- a/proposal/myrmidon/src/java/org/apache/myrmidon/interfaces/service/MultiSourceServiceManager.java +++ b/proposal/myrmidon/src/java/org/apache/myrmidon/interfaces/service/MultiSourceServiceManager.java @@ -40,9 +40,10 @@ public class MultiSourceServiceManager * * @param serviceType The service interface. */ - public boolean hasService( Class serviceType ) + public boolean hasService( final Class serviceType ) { - for( int i = 0; i < m_sources.size(); i++ ) + final int size = m_sources.size(); + for( int i = 0; i < size; i++ ) { final ServiceManager serviceManager = (ServiceManager)m_sources.get( i ); if( serviceManager.hasService( serviceType ) ) @@ -61,10 +62,11 @@ public class MultiSourceServiceManager * implement the service interface. * @throws ServiceException If the service does not exist. */ - public Object getService( Class serviceType ) + public Object getService( final Class serviceType ) throws ServiceException { - for( int i = 0; i < m_sources.size(); i++ ) + final int size = m_sources.size(); + for( int i = 0; i < size; i++ ) { final ServiceManager serviceManager = (ServiceManager)m_sources.get( i ); if( serviceManager.hasService( serviceType ) )