From c665fdcd496e4fac2b57d9ba5481a8074c13861b Mon Sep 17 00:00:00 2001
From: Conor MacNeill <conor@apache.org>
Date: Wed, 5 Feb 2003 13:14:33 +0000
Subject: [PATCH] Add warnings about the interaction of filters and binary
 files PR:	16780

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@273990 13f79535-47bb-0310-9956-ffa450edef68
---
 docs/manual/CoreTasks/copy.html      | 10 ++++++++++
 docs/manual/CoreTypes/filterset.html |  7 +++++++
 2 files changed, 17 insertions(+)

diff --git a/docs/manual/CoreTasks/copy.html b/docs/manual/CoreTasks/copy.html
index eb54a84b0..d9c7c9311 100644
--- a/docs/manual/CoreTasks/copy.html
+++ b/docs/manual/CoreTasks/copy.html
@@ -13,10 +13,20 @@
 only copied if the source file is newer than the destination file,
 or when the destination file does not exist.  However, you can explicitly
 overwrite files with the <code>overwrite</code> attribute.</p>
+
 <p><a href="../CoreTypes/fileset.html">FileSet</a>s are used to select a
 set of files to copy.
 To use a <code>&lt;fileset&gt;</code>, the <code>todir</code> attribute
 must be set.</p>
+
+<p>
+<strong>Note: </strong>If you employ filters in your copy operation, you should 
+limit the copy to text files. Binary files will be corrupted by the copy operation.
+This applies whether the filters are implicitly defined by the 
+<a href="filter.html">filter</a> task or explicitly provided to the copy
+operation as <a href="../CoreTypes/filterset.html">filtersets</a>
+</p>
+ 
 <h3>Parameters</h3>
 <table border="1" cellpadding="2" cellspacing="0">
   <tr>
diff --git a/docs/manual/CoreTypes/filterset.html b/docs/manual/CoreTypes/filterset.html
index 3611b3dfa..cd1062adc 100644
--- a/docs/manual/CoreTypes/filterset.html
+++ b/docs/manual/CoreTypes/filterset.html
@@ -28,6 +28,13 @@ filters.</p>
 <p>Filtersets are used for doing 
 replacements in tasks such as <code>&lt;copy&gt;</code>, etc.</p>
 
+<p>
+<strong>Note: </strong>When a filterset is used in an operation, the files are 
+processed in text mode and the filters applied line by line. This means that
+the copy operations will typically corrupt binary files. When applying filters
+you should ensure that the set of files being filtered are all text files.
+</p>
+
 <H2>Filterset</H2>
 
 <TABLE cellSpacing=0 cellPadding=2 border=1>