From 9bbce816f12e446c0b79360d11d64575206be79e Mon Sep 17 00:00:00 2001 From: Peter Reilly Date: Sat, 18 Nov 2006 18:05:16 +0000 Subject: [PATCH] checkstyle git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@476574 13f79535-47bb-0310-9956-ffa450edef68 --- .../optional/native2ascii/DefaultNative2Ascii.java | 9 +++++++++ .../optional/native2ascii/KaffeNative2Ascii.java | 5 ++++- .../optional/native2ascii/Native2AsciiAdapter.java | 3 ++- .../native2ascii/Native2AsciiAdapterFactory.java | 1 + .../taskdefs/optional/native2ascii/SunNative2Ascii.java | 2 ++ 5 files changed, 18 insertions(+), 2 deletions(-) diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/native2ascii/DefaultNative2Ascii.java b/src/main/org/apache/tools/ant/taskdefs/optional/native2ascii/DefaultNative2Ascii.java index b2c7318e9..ed9f8f35b 100644 --- a/src/main/org/apache/tools/ant/taskdefs/optional/native2ascii/DefaultNative2Ascii.java +++ b/src/main/org/apache/tools/ant/taskdefs/optional/native2ascii/DefaultNative2Ascii.java @@ -31,11 +31,17 @@ import org.apache.tools.ant.types.Commandline; */ public abstract class DefaultNative2Ascii implements Native2AsciiAdapter { + /** No-arg constructor. */ public DefaultNative2Ascii() { } /** * Splits the task into setting up the command line switches + * @param args the native 2 ascii arguments. + * @param srcFile the source file. + * @param destFile the destination file. + * @return run if the conversion was successful. + * @throws BuildException if there is a problem. * (delegated to {@link #setup setup}), adding the file names * (delegated to {@link #addFiles addFiles}) and running the tool * (delegated to {@link #run run}). @@ -57,6 +63,7 @@ public abstract class DefaultNative2Ascii implements Native2AsciiAdapter { * @param cmd Command line to add to * @param args provides the user-setting and access to Ant's * logging system. + * @throws BuildException if there was a problem. */ protected void setup(Commandline cmd, Native2Ascii args) throws BuildException { @@ -77,6 +84,7 @@ public abstract class DefaultNative2Ascii implements Native2AsciiAdapter { * @param log provides access to Ant's logging system. * @param src the source file * @param dest the destination file + * @throws BuildException if there was a problem. */ protected void addFiles(Commandline cmd, ProjectComponent log, File src, File dest) throws BuildException { @@ -90,6 +98,7 @@ public abstract class DefaultNative2Ascii implements Native2AsciiAdapter { * @param cmd Command line to execute * @param log provides access to Ant's logging system. * @return whether execution was successful + * @throws BuildException if there was a problem. */ protected abstract boolean run(Commandline cmd, ProjectComponent log) throws BuildException; diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/native2ascii/KaffeNative2Ascii.java b/src/main/org/apache/tools/ant/taskdefs/optional/native2ascii/KaffeNative2Ascii.java index 75e34a343..cd4d36a8b 100644 --- a/src/main/org/apache/tools/ant/taskdefs/optional/native2ascii/KaffeNative2Ascii.java +++ b/src/main/org/apache/tools/ant/taskdefs/optional/native2ascii/KaffeNative2Ascii.java @@ -42,6 +42,7 @@ public final class KaffeNative2Ascii extends DefaultNative2Ascii { */ public static final String IMPLEMENTATION_NAME = "kaffe"; + /** {@inheritDoc} */ protected void setup(Commandline cmd, Native2Ascii args) throws BuildException { if (args.getReverse()) { @@ -50,6 +51,7 @@ public final class KaffeNative2Ascii extends DefaultNative2Ascii { super.setup(cmd, args); } + /** {@inheritDoc} */ protected boolean run(Commandline cmd, ProjectComponent log) throws BuildException { ExecuteJava ej = new ExecuteJava(); @@ -77,9 +79,10 @@ public final class KaffeNative2Ascii extends DefaultNative2Ascii { try { return Class.forName(N2A_CLASSNAMES[i]); } catch (ClassNotFoundException cnfe) { + // Ignore } } return null; } -} \ No newline at end of file +} diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/native2ascii/Native2AsciiAdapter.java b/src/main/org/apache/tools/ant/taskdefs/optional/native2ascii/Native2AsciiAdapter.java index 35c611dfb..4bcac3b1c 100644 --- a/src/main/org/apache/tools/ant/taskdefs/optional/native2ascii/Native2AsciiAdapter.java +++ b/src/main/org/apache/tools/ant/taskdefs/optional/native2ascii/Native2AsciiAdapter.java @@ -35,7 +35,8 @@ public interface Native2AsciiAdapter { * @param srcFile the source to convert * @param destFile where to send output to * @return whether the conversion has been successful. + * @throws BuildException if there was a problem. */ boolean convert(Native2Ascii args, File srcFile, File destFile) throws BuildException; -} \ No newline at end of file +} diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/native2ascii/Native2AsciiAdapterFactory.java b/src/main/org/apache/tools/ant/taskdefs/optional/native2ascii/Native2AsciiAdapterFactory.java index aed2c56ac..08260673e 100644 --- a/src/main/org/apache/tools/ant/taskdefs/optional/native2ascii/Native2AsciiAdapterFactory.java +++ b/src/main/org/apache/tools/ant/taskdefs/optional/native2ascii/Native2AsciiAdapterFactory.java @@ -52,6 +52,7 @@ public class Native2AsciiAdapterFactory { * @param log a ProjectComponent instance used to access Ant's * logging system. * @return The adapter to use. + * @throws BuildException if there was a problem. */ public static Native2AsciiAdapter getAdapter(String choice, ProjectComponent log) diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/native2ascii/SunNative2Ascii.java b/src/main/org/apache/tools/ant/taskdefs/optional/native2ascii/SunNative2Ascii.java index eacadab18..101db7cce 100644 --- a/src/main/org/apache/tools/ant/taskdefs/optional/native2ascii/SunNative2Ascii.java +++ b/src/main/org/apache/tools/ant/taskdefs/optional/native2ascii/SunNative2Ascii.java @@ -35,6 +35,7 @@ public final class SunNative2Ascii extends DefaultNative2Ascii { */ public static final String IMPLEMENTATION_NAME = "sun"; + /** {@inheritDoc} */ protected void setup(Commandline cmd, Native2Ascii args) throws BuildException { if (args.getReverse()) { @@ -43,6 +44,7 @@ public final class SunNative2Ascii extends DefaultNative2Ascii { super.setup(cmd, args); } + /** {@inheritDoc} */ protected boolean run(Commandline cmd, ProjectComponent log) throws BuildException { try {