From 98c94f2ed3cb2c8a28812d56f60afdeb69574c72 Mon Sep 17 00:00:00 2001 From: Peter Reilly Date: Wed, 3 Oct 2007 12:49:47 +0000 Subject: [PATCH] checkstyle git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@581587 13f79535-47bb-0310-9956-ffa450edef68 --- src/main/org/apache/tools/ant/types/resources/Union.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/main/org/apache/tools/ant/types/resources/Union.java b/src/main/org/apache/tools/ant/types/resources/Union.java index 9c1edb8b2..c0c72b259 100644 --- a/src/main/org/apache/tools/ant/types/resources/Union.java +++ b/src/main/org/apache/tools/ant/types/resources/Union.java @@ -104,14 +104,15 @@ public class Union extends BaseResourceCollectionContainer { //preserve order-encountered using a list; enforce set logic manually: // (LinkedHashSet better, but JDK 1.4+) ArrayList union = new ArrayList(rc.size() * 2); - Set _union = new HashSet(rc.size() * 2); + // Use a set as list.contains() can be expensive for lots of resources + Set set = new HashSet(rc.size() * 2); for (Iterator rcIter = rc.iterator(); rcIter.hasNext();) { for (Iterator r = nextRC(rcIter).iterator(); r.hasNext();) { Object o = r.next(); if (asString) { o = o.toString(); } - if (_union.add(o)) { + if (set.add(o)) { union.add(o); } }