Browse Source

Made sure signjar was actually executing command

Fixing a audit violation


git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@270920 13f79535-47bb-0310-9956-ffa450edef68
master
Peter Donald 23 years ago
parent
commit
90ff09d91d
1 changed files with 3 additions and 3 deletions
  1. +3
    -3
      proposal/myrmidon/src/java/org/apache/antlib/security/SignJar.java

+ 3
- 3
proposal/myrmidon/src/java/org/apache/antlib/security/SignJar.java View File

@@ -150,7 +150,8 @@ public class SignJar
//Assume null != filesets //Assume null != filesets


// deal with the filesets // deal with the filesets
for( int i = 0; i < m_filesets.size(); i++ )
final int size = m_filesets.size();
for( int i = 0; i < size; i++ )
{ {
final FileSet fileSet = (FileSet)m_filesets.get( i ); final FileSet fileSet = (FileSet)m_filesets.get( i );
final DirectoryScanner scanner = ScannerUtil.getDirectoryScanner( fileSet ); final DirectoryScanner scanner = ScannerUtil.getDirectoryScanner( fileSet );
@@ -288,14 +289,13 @@ public class SignJar
return; return;
} }


final StringBuffer sb = new StringBuffer();

final String message = "Signing Jar : " + jarSource.getAbsolutePath(); final String message = "Signing Jar : " + jarSource.getAbsolutePath();
getLogger().info( message ); getLogger().info( message );


final Commandline cmd = buildCommand( jarTarget, jarSource ); final Commandline cmd = buildCommand( jarTarget, jarSource );
final Execute2 exe = new Execute2(); final Execute2 exe = new Execute2();
setupLogger( exe ); setupLogger( exe );
exe.setCommandline( cmd.getCommandline() );
try try
{ {
exe.execute(); exe.execute();


Loading…
Cancel
Save