From 764c1a617bb9333e5914dfb5a10a17c5295da43b Mon Sep 17 00:00:00 2001 From: Peter Donald Date: Sun, 27 Jan 2002 00:26:01 +0000 Subject: [PATCH] Dont test booleans againstr true/false in condition expressions Fixing a audit violation git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@270922 13f79535-47bb-0310-9956-ffa450edef68 --- .../src/main/org/apache/tools/ant/taskdefs/file/Mkdir.java | 4 ++-- .../src/todo/org/apache/tools/ant/taskdefs/file/Mkdir.java | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/file/Mkdir.java b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/file/Mkdir.java index 7214d42cc..be7b17f76 100644 --- a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/file/Mkdir.java +++ b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/file/Mkdir.java @@ -44,8 +44,8 @@ public class Mkdir if( !m_dir.exists() ) { - boolean result = m_dir.mkdirs(); - if( result == false ) + final boolean result = m_dir.mkdirs(); + if( !result ) { final String message = "Directory " + m_dir.getAbsolutePath() + " creation was not " + "successful for an unknown reason"; diff --git a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/file/Mkdir.java b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/file/Mkdir.java index 7214d42cc..be7b17f76 100644 --- a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/file/Mkdir.java +++ b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/file/Mkdir.java @@ -44,8 +44,8 @@ public class Mkdir if( !m_dir.exists() ) { - boolean result = m_dir.mkdirs(); - if( result == false ) + final boolean result = m_dir.mkdirs(); + if( !result ) { final String message = "Directory " + m_dir.getAbsolutePath() + " creation was not " + "successful for an unknown reason";