From 6a1e5bf81d8551496caae2d0a90a40c339752681 Mon Sep 17 00:00:00 2001 From: Stefan Bodewig Date: Mon, 24 Jun 2013 15:50:56 +0000 Subject: [PATCH] More robust handling of line-feeds - in particular make it work on Windows - thanks Uwe! git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@1496104 13f79535-47bb-0310-9956-ffa450edef68 --- .../org/apache/tools/ant/taskdefs/Javadoc.java | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/src/main/org/apache/tools/ant/taskdefs/Javadoc.java b/src/main/org/apache/tools/ant/taskdefs/Javadoc.java index b2d2093f3..913a4af98 100644 --- a/src/main/org/apache/tools/ant/taskdefs/Javadoc.java +++ b/src/main/org/apache/tools/ant/taskdefs/Javadoc.java @@ -2456,9 +2456,10 @@ public class Javadoc extends Task { + "classpath."); } try { - fixData = FileUtils.readFully(new InputStreamReader(in, "US-ASCII")).trim() - .replace("\r\n", StringUtils.LINE_SEP) - .replace("\n", StringUtils.LINE_SEP); + fixData = + fixLineFeeds(FileUtils + .readFully(new InputStreamReader(in, "US-ASCII"))) + .trim(); } finally { FileUtils.close(in); } @@ -2490,7 +2491,8 @@ public class Javadoc extends Task { String fileContents; try { fileContents = - FileUtils.safeReadFully(new InputStreamReader(fin, enc)); + fixLineFeeds(FileUtils + .safeReadFully(new InputStreamReader(fin, enc))); } finally { FileUtils.close(fin); } @@ -2515,6 +2517,11 @@ public class Javadoc extends Task { return 0; } + private String fixLineFeeds(String orig) { + return orig.replace("\r\n", "\n") + .replace("\n", StringUtils.LINE_SEP); + } + private String patchContent(String fileContents, String fixData) { // using regexes here looks like overkill int start = fileContents.indexOf(LOAD_FRAME);