From 5ecbfc2436bdcb618dba0414ccead746e699c05a Mon Sep 17 00:00:00 2001
From: Peter Reilly <peterreilly@apache.org>
Date: Thu, 1 Apr 2004 13:06:45 +0000
Subject: [PATCH] <parallel>: failonany was tested even if the task succeeded.
 PR: 28122 Reported by: Oliver Dungey

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@276270 13f79535-47bb-0310-9956-ffa450edef68
---
 WHATSNEW                                             | 2 ++
 src/main/org/apache/tools/ant/taskdefs/Parallel.java | 6 +++---
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/WHATSNEW b/WHATSNEW
index d5a882dd1..6856f435b 100644
--- a/WHATSNEW
+++ b/WHATSNEW
@@ -97,6 +97,8 @@ Fixed bugs:
 
 * wrong compare used in ProjectComponent for logging. Bugzilla Report 28070.
 
+* failOnAny attribute for <parallel> was broken. Bugzilla Report 28122.
+
 Other changes:
 --------------
 
diff --git a/src/main/org/apache/tools/ant/taskdefs/Parallel.java b/src/main/org/apache/tools/ant/taskdefs/Parallel.java
index e6697c396..1721dfb49 100644
--- a/src/main/org/apache/tools/ant/taskdefs/Parallel.java
+++ b/src/main/org/apache/tools/ant/taskdefs/Parallel.java
@@ -417,12 +417,12 @@ public class Parallel extends Task
                 task.perform();
             } catch (Throwable t) {
                 exception = t;
+                if (failOnAny) {
+                    stillRunning = false;
+                }
             } finally {
                 synchronized (semaphore) {
                     finished = true;
-                    if (failOnAny) {
-                        stillRunning = false;
-                    }
                     semaphore.notifyAll();
                 }
             }