From 2dc4a513d97b9d55959e691cf8324915c9d2b0a3 Mon Sep 17 00:00:00 2001
From: Stefan Bodewig <bodewig@apache.org>
Date: Wed, 17 Feb 2010 14:39:42 +0000
Subject: [PATCH] round out test and document the bug

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@910997 13f79535-47bb-0310-9956-ffa450edef68
---
 WHATSNEW                                             |  3 +++
 .../org/apache/tools/ant/util/VectorSetTest.java     | 12 +++++++++---
 2 files changed, 12 insertions(+), 3 deletions(-)

diff --git a/WHATSNEW b/WHATSNEW
index fd76f14ab..91af5c957 100644
--- a/WHATSNEW
+++ b/WHATSNEW
@@ -25,6 +25,9 @@ Fixed bugs:
    META-INF/application.xml files to be added.
    Bugzilla Report 6836.
 
+ * VectorSet#remove(Object) would fail if the size of the vector
+   equaled its capacity.
+
 Other changes:
 --------------
 
diff --git a/src/tests/junit/org/apache/tools/ant/util/VectorSetTest.java b/src/tests/junit/org/apache/tools/ant/util/VectorSetTest.java
index 5d038a246..f0f70780f 100644
--- a/src/tests/junit/org/apache/tools/ant/util/VectorSetTest.java
+++ b/src/tests/junit/org/apache/tools/ant/util/VectorSetTest.java
@@ -113,7 +113,8 @@ public class VectorSetTest extends TestCase {
         v = new VectorSet(3, 1);
         Object a = new Object();
         v.add(a);
-        v.add(new Object());
+        Object b = new Object();
+        v.add(b);
         v.add(O);
         assertEquals(3, v.size());
         assertEquals(3, v.capacity());
@@ -121,6 +122,7 @@ public class VectorSetTest extends TestCase {
         assertEquals(2, v.size());
         assertFalse(v.remove(O));
         assertSame(a, v.elementAt(0));
+        assertSame(b, v.elementAt(1));
     }
 
     public void testRemoveAtFrontWhenSizeEqualsCapacity() {
@@ -128,13 +130,15 @@ public class VectorSetTest extends TestCase {
         v.add(O);
         Object a = new Object();
         v.add(a);
-        v.add(new Object());
+        Object b = new Object();
+        v.add(b);
         assertEquals(3, v.size());
         assertEquals(3, v.capacity());
         assertTrue(v.remove(O));
         assertEquals(2, v.size());
         assertFalse(v.remove(O));
         assertSame(a, v.elementAt(0));
+        assertSame(b, v.elementAt(1));
     }
 
     public void testRemoveInMiddleWhenSizeEqualsCapacity() {
@@ -142,13 +146,15 @@ public class VectorSetTest extends TestCase {
         Object a = new Object();
         v.add(a);
         v.add(O);
-        v.add(new Object());
+        Object b = new Object();
+        v.add(b);
         assertEquals(3, v.size());
         assertEquals(3, v.capacity());
         assertTrue(v.remove(O));
         assertEquals(2, v.size());
         assertFalse(v.remove(O));
         assertSame(a, v.elementAt(0));
+        assertSame(b, v.elementAt(1));
     }
 
     public void testRemoveAll() {