Browse Source

make the Regex static, specify flags

pull/1260/head
Chris Johnston 6 years ago
parent
commit
ec23a80c1d
1 changed files with 2 additions and 3 deletions
  1. +2
    -3
      src/Discord.Net.Webhook/DiscordWebhookClient.cs

+ 2
- 3
src/Discord.Net.Webhook/DiscordWebhookClient.cs View File

@@ -32,7 +32,7 @@ namespace Discord.Webhook
: this(webhookUrl, new DiscordRestConfig()) { } : this(webhookUrl, new DiscordRestConfig()) { }


// regex pattern to match webhook urls // regex pattern to match webhook urls
private const string WebhookUrlRegex = @"^.+.com\/api\/webhooks\/([\d]+)\/([A-Za-z0-9_-]+)$";
private static Regex WebhookUrlRegex = new Regex(@"^.+.com\/api\/webhooks\/([\d]+)\/([a-z0-9_-]+)$", RegexOptions.Compiled | RegexOptions.IgnoreCase);


/// <summary> Creates a new Webhook Discord client. </summary> /// <summary> Creates a new Webhook Discord client. </summary>
public DiscordWebhookClient(ulong webhookId, string webhookToken, DiscordRestConfig config) public DiscordWebhookClient(ulong webhookId, string webhookToken, DiscordRestConfig config)
@@ -66,8 +66,7 @@ namespace Discord.Webhook
// thrown when groups are not populated/valid, or when there is no match // thrown when groups are not populated/valid, or when there is no match
ArgumentException ex() ArgumentException ex()
=> new ArgumentException(paramName: nameof(webhookUrl), message: "The given webhook Url was not in a valid format."); => new ArgumentException(paramName: nameof(webhookUrl), message: "The given webhook Url was not in a valid format.");
var re = new Regex(WebhookUrlRegex);
var match = re.Match(webhookUrl);
var match = WebhookUrlRegex.Match(webhookUrl);
if (match != null) if (match != null)
{ {
// ensure that the first group is a ulong, set the _webhookId // ensure that the first group is a ulong, set the _webhookId


Loading…
Cancel
Save