From d8cc1072f1fe467b3701fed863b5a2aa3fb79be3 Mon Sep 17 00:00:00 2001 From: Chris Johnston Date: Sun, 15 Sep 2019 22:27:15 -0700 Subject: [PATCH] use only stringbuilder for args instead of string interpolation --- src/Discord.Net.Rest/DiscordRestApiClient.cs | 20 +++++++++++++++----- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/src/Discord.Net.Rest/DiscordRestApiClient.cs b/src/Discord.Net.Rest/DiscordRestApiClient.cs index 6fe11d176..0ca7ef7a6 100644 --- a/src/Discord.Net.Rest/DiscordRestApiClient.cs +++ b/src/Discord.Net.Rest/DiscordRestApiClient.cs @@ -1321,15 +1321,25 @@ namespace Discord.API var ids = new BucketIds(guildId: guildId); Expression> endpoint; - var query = new StringBuilder(); + var queryArgs = new StringBuilder(); if (args.BeforeEntryId.IsSpecified) - query.Append($"&before={args.BeforeEntryId.Value}"); + { + queryArgs.Append("&before=") + .Append(args.BeforeEntryId); + } if (args.UserId.IsSpecified) - query.Append($"&user_id={args.UserId.Value}"); + { + queryArgs.Append("&user_id=") + .Append(args.UserId.Value); + } if (args.ActionType.IsSpecified) - query.Append($"&action_type={args.ActionType.Value}"); + { + queryArgs.Append("&action_type=") + .Append(args.ActionType.Value); + } - endpoint = () => $"guilds/{guildId}/audit-logs?limit={limit}{query.ToString()}"; + // still use string interp for the query w/o params, as this is necessary for CreateBucketId + endpoint = () => $"guilds/{guildId}/audit-logs?limit={limit}{queryArgs.ToString()}"; return await SendAsync("GET", endpoint, ids, options: options).ConfigureAwait(false); }