From c3822347dda54cb91b03b531aefd95eb3a168f7e Mon Sep 17 00:00:00 2001 From: ericmck2000 Date: Thu, 23 Aug 2018 09:41:21 -0500 Subject: [PATCH] Reused timeSpan variable from previous IF statement. Re-utilized previous timespan variable. Minor optimization. --- src/Discord.Net.Commands/Readers/TimeSpanTypeReader.cs | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/src/Discord.Net.Commands/Readers/TimeSpanTypeReader.cs b/src/Discord.Net.Commands/Readers/TimeSpanTypeReader.cs index 12d221beb..044146617 100644 --- a/src/Discord.Net.Commands/Readers/TimeSpanTypeReader.cs +++ b/src/Discord.Net.Commands/Readers/TimeSpanTypeReader.cs @@ -34,13 +34,12 @@ namespace Discord.Commands //First, try using the built-in TimeSpan.Parse. (Default Implementation) if (TimeSpan.TryParseExact(data, _formats, CultureInfo.InvariantCulture, out var timeSpan)) return Task.FromResult(TypeReaderResult.FromSuccess(timeSpan)); - //@ericmck2000 - Try using the regular TimeSpan.TryPrase. Greatly improves success rate. - else if (TimeSpan.TryParse(data, out var time)) - return Task.FromResult(TypeReaderResult.FromSuccess(time)); + //Try using the regular TimeSpan.TryPrase. Greatly improves success rate. + else if (TimeSpan.TryParse(data, out timeSpan)) + return Task.FromResult(TypeReaderResult.FromSuccess(timeSpan)); + //Else, return parse failed error. else - { return Task.FromResult(TypeReaderResult.FromError(CommandError.ParseFailed, "Failed to parse TimeSpan")); - } } } }