From 59587122675c69269c852b6a53de1aff68914838 Mon Sep 17 00:00:00 2001 From: Joe4evr Date: Thu, 8 Mar 2018 22:59:39 +0100 Subject: [PATCH 1/2] Allow replacing a default typereader globally --- src/Discord.Net.Commands/CommandService.cs | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/Discord.Net.Commands/CommandService.cs b/src/Discord.Net.Commands/CommandService.cs index d79a3a03b..535e7b252 100644 --- a/src/Discord.Net.Commands/CommandService.cs +++ b/src/Discord.Net.Commands/CommandService.cs @@ -263,6 +263,14 @@ namespace Discord.Commands } return null; } + public void ReplaceDefaultTypereader(TypeReader reader) + { + var key = typeof(T); + if (_defaultTypeReaders.ContainsKey(key)) + { + _defaultTypeReaders.AddOrUpdate(key, k => throw new Exception("This shouldn't happen?"), (k, v) => reader); + } + } //Execution public SearchResult Search(ICommandContext context, int argPos) From d3b0d071e7028b568e8dddeeeb471c77129b8854 Mon Sep 17 00:00:00 2001 From: Joe4evr Date: Thu, 8 Mar 2018 23:02:27 +0100 Subject: [PATCH 2/2] Refactor with non-generic method for symmetry with AddTypeReader --- src/Discord.Net.Commands/CommandService.cs | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/Discord.Net.Commands/CommandService.cs b/src/Discord.Net.Commands/CommandService.cs index 535e7b252..f5b807b42 100644 --- a/src/Discord.Net.Commands/CommandService.cs +++ b/src/Discord.Net.Commands/CommandService.cs @@ -264,11 +264,12 @@ namespace Discord.Commands return null; } public void ReplaceDefaultTypereader(TypeReader reader) + => ReplaceDefaultTypereader(typeof(T), reader); + public void ReplaceDefaultTypereader(Type type, TypeReader reader) { - var key = typeof(T); - if (_defaultTypeReaders.ContainsKey(key)) + if (_defaultTypeReaders.ContainsKey(type)) { - _defaultTypeReaders.AddOrUpdate(key, k => throw new Exception("This shouldn't happen?"), (k, v) => reader); + _defaultTypeReaders.AddOrUpdate(type, k => throw new Exception("This shouldn't happen?"), (k, v) => reader); } }