From 71a1adb6815bebea55be746bcad087a136ca5aa8 Mon Sep 17 00:00:00 2001 From: FiniteReality Date: Fri, 23 Jun 2017 17:14:21 +0100 Subject: [PATCH] Make RuntimeResult abstract It never really made sense to have it instantiable in the first place, frankly. --- src/Discord.Net.Commands/Results/RuntimeResult.cs | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/src/Discord.Net.Commands/Results/RuntimeResult.cs b/src/Discord.Net.Commands/Results/RuntimeResult.cs index 6685290b8..2a326a7a3 100644 --- a/src/Discord.Net.Commands/Results/RuntimeResult.cs +++ b/src/Discord.Net.Commands/Results/RuntimeResult.cs @@ -6,7 +6,7 @@ using System.Text; namespace Discord.Commands { [DebuggerDisplay(@"{DebuggerDisplay,nq}")] - public class RuntimeResult : IResult + public abstract class RuntimeResult : IResult { protected RuntimeResult(CommandError? error, string reason) { @@ -21,13 +21,6 @@ namespace Discord.Commands string IResult.ErrorReason => Reason; - public static RuntimeResult FromSuccess(string reason = null) => - new RuntimeResult(null, reason); - public static RuntimeResult FromError(string reason) => - new RuntimeResult(CommandError.Unsuccessful, reason); - public static RuntimeResult FromError(IResult result) => - new RuntimeResult(result.Error, result.ErrorReason); - public override string ToString() => Reason ?? (IsSuccess ? "Successful" : "Unsuccessful"); private string DebuggerDisplay => IsSuccess ? $"Success: {Reason ?? "No Reason"}" : $"{Error}: {Reason}"; }