From 928b5d97574eda07b60c246fe9bccc93abe91c2b Mon Sep 17 00:00:00 2001 From: Cenk Ergen <57065323+Cenngo@users.noreply.github.com> Date: Mon, 1 Aug 2022 20:38:19 +0300 Subject: [PATCH 1/3] Apply suggestions from code review Co-authored-by: Armano den Boef <68127614+Rozen4334@users.noreply.github.com> --- .../Interactions/ContextMenus/MessageCommandBuilder.cs | 2 +- .../Interactions/ContextMenus/UserCommandBuilder.cs | 2 +- .../Entities/Interactions/IApplicationCommandOption.cs | 8 ++++---- .../Interactions/IApplicationCommandOptionChoice.cs | 4 ++-- .../LocalizationManagers/ILocalizationManager.cs | 2 +- 5 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/Discord.Net.Core/Entities/Interactions/ContextMenus/MessageCommandBuilder.cs b/src/Discord.Net.Core/Entities/Interactions/ContextMenus/MessageCommandBuilder.cs index ca6995b69..ed49c685d 100644 --- a/src/Discord.Net.Core/Entities/Interactions/ContextMenus/MessageCommandBuilder.cs +++ b/src/Discord.Net.Core/Entities/Interactions/ContextMenus/MessageCommandBuilder.cs @@ -100,7 +100,7 @@ namespace Discord /// /// Sets the collection. /// - /// Localization dictionary for the name field of this command. + /// The localization dictionary to use for the name field of this command. /// /// Thrown if is null. /// Thrown if any dictionary key is an invalid locale string. diff --git a/src/Discord.Net.Core/Entities/Interactions/ContextMenus/UserCommandBuilder.cs b/src/Discord.Net.Core/Entities/Interactions/ContextMenus/UserCommandBuilder.cs index 37469d6c3..d8bb2e056 100644 --- a/src/Discord.Net.Core/Entities/Interactions/ContextMenus/UserCommandBuilder.cs +++ b/src/Discord.Net.Core/Entities/Interactions/ContextMenus/UserCommandBuilder.cs @@ -98,7 +98,7 @@ namespace Discord /// /// Sets the collection. /// - /// Localization dictionary for the name field of this command. + /// The localization dictionary to use for the name field of this command. /// The current builder. /// Thrown if is null. /// Thrown if any dictionary key is an invalid locale string. diff --git a/src/Discord.Net.Core/Entities/Interactions/IApplicationCommandOption.cs b/src/Discord.Net.Core/Entities/Interactions/IApplicationCommandOption.cs index 72114fb53..7e8c93339 100644 --- a/src/Discord.Net.Core/Entities/Interactions/IApplicationCommandOption.cs +++ b/src/Discord.Net.Core/Entities/Interactions/IApplicationCommandOption.cs @@ -63,17 +63,17 @@ namespace Discord IReadOnlyCollection ChannelTypes { get; } /// - /// Gets the localization dictionary for the name field of this command. + /// Gets the localization dictionary for the name field of this command option. /// IReadOnlyDictionary NameLocalizations { get; } /// - /// Gets the localization dictionary for the description field of this command. + /// Gets the localization dictionary for the description field of this command option. /// IReadOnlyDictionary DescriptionLocalizations { get; } /// - /// Gets the localized name of this command. + /// Gets the localized name of this command option. /// /// /// Only returned when the `withLocalizations` query parameter is set to when requesting the command. @@ -81,7 +81,7 @@ namespace Discord string NameLocalized { get; } /// - /// Gets the localized description of this command. + /// Gets the localized description of this command option. /// /// /// Only returned when the `withLocalizations` query parameter is set to true when requesting the command. diff --git a/src/Discord.Net.Core/Entities/Interactions/IApplicationCommandOptionChoice.cs b/src/Discord.Net.Core/Entities/Interactions/IApplicationCommandOptionChoice.cs index df52f9cd6..3f76bae72 100644 --- a/src/Discord.Net.Core/Entities/Interactions/IApplicationCommandOptionChoice.cs +++ b/src/Discord.Net.Core/Entities/Interactions/IApplicationCommandOptionChoice.cs @@ -18,12 +18,12 @@ namespace Discord object Value { get; } /// - /// Gets the localization dictionary for the name field of this command. + /// Gets the localization dictionary for the name field of this command option. /// IReadOnlyDictionary NameLocalizations { get; } /// - /// Gets the localized name of this command. + /// Gets the localized name of this command option. /// /// /// Only returned when the `withLocalizations` query parameter is set to when requesting the command. diff --git a/src/Discord.Net.Interactions/LocalizationManagers/ILocalizationManager.cs b/src/Discord.Net.Interactions/LocalizationManagers/ILocalizationManager.cs index 1c2216fee..13b155292 100644 --- a/src/Discord.Net.Interactions/LocalizationManagers/ILocalizationManager.cs +++ b/src/Discord.Net.Interactions/LocalizationManagers/ILocalizationManager.cs @@ -5,7 +5,7 @@ using System.Threading.Tasks; namespace Discord.Interactions { /// - /// Respresents localization provider for Discord Application Commands. + /// Respresents a localization provider for Discord Application Commands. /// public interface ILocalizationManager { From 76898286e4e061a177879d28d083367fa504714f Mon Sep 17 00:00:00 2001 From: Cenk Ergen <57065323+Cenngo@users.noreply.github.com> Date: Mon, 1 Aug 2022 20:40:17 +0300 Subject: [PATCH 2/3] Apply suggestions from code review Co-authored-by: Armano den Boef <68127614+Rozen4334@users.noreply.github.com> --- .../SlashCommands/SlashCommandBuilder.cs | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/Discord.Net.Core/Entities/Interactions/SlashCommands/SlashCommandBuilder.cs b/src/Discord.Net.Core/Entities/Interactions/SlashCommands/SlashCommandBuilder.cs index c6b8195a0..b2f00d4f6 100644 --- a/src/Discord.Net.Core/Entities/Interactions/SlashCommands/SlashCommandBuilder.cs +++ b/src/Discord.Net.Core/Entities/Interactions/SlashCommands/SlashCommandBuilder.cs @@ -282,7 +282,7 @@ namespace Discord /// /// Sets the collection. /// - /// Localization dictionary for the name field of this command. + /// The localization dictionary to use for the name field of this command. /// /// Thrown if is null. /// Thrown if any dictionary key is an invalid locale string. @@ -306,7 +306,7 @@ namespace Discord /// /// Sets the collection. /// - /// Localization dictionary for the name field of this command. + /// The localization dictionary to use for the description field of this command. /// /// Thrown if is null. /// Thrown if any dictionary key is an invalid locale string. @@ -640,7 +640,7 @@ namespace Discord /// /// The name of the choice. /// The value of the choice. - /// Localization dictionary for the description field of this command. + /// The localization dictionary for to use the name field of this command option choice. /// The current builder. public SlashCommandOptionBuilder AddChoice(string name, int value, IDictionary nameLocalizations = null) { @@ -652,7 +652,7 @@ namespace Discord /// /// The name of the choice. /// The value of the choice. - /// Localization dictionary for the description field of this command. + /// The localization dictionary for to use the name field of this command option choice. /// The current builder. public SlashCommandOptionBuilder AddChoice(string name, string value, IDictionary nameLocalizations = null) { @@ -676,7 +676,7 @@ namespace Discord /// /// The name of the choice. /// The value of the choice. - /// Localization dictionary for the description field of this command. + /// The localization dictionary to use for the name field of this command option choice. /// The current builder. public SlashCommandOptionBuilder AddChoice(string name, float value, IDictionary nameLocalizations = null) { @@ -688,7 +688,7 @@ namespace Discord /// /// The name of the choice. /// The value of the choice. - /// Localization dictionary for the description field of this command. + /// The localization dictionary to use for the name field of this command option choice. /// The current builder. public SlashCommandOptionBuilder AddChoice(string name, long value, IDictionary nameLocalizations = null) { @@ -830,7 +830,7 @@ namespace Discord /// /// Sets the collection. /// - /// Localization dictionary for the name field of this command. + /// The localization dictionary to use for the name field of this command option. /// The current builder. /// Thrown if is null. /// Thrown if any dictionary key is an invalid locale string. @@ -854,7 +854,7 @@ namespace Discord /// /// Sets the collection. /// - /// Localization dictionary for the description field of this command. + /// The localization dictionary to use for the description field of this command option. /// The current builder. /// Thrown if is null. /// Thrown if any dictionary key is an invalid locale string. From d31a52b69f55b8314abb4aa0865d0318e623dff7 Mon Sep 17 00:00:00 2001 From: Cenk Ergen <57065323+Cenngo@users.noreply.github.com> Date: Mon, 1 Aug 2022 20:40:41 +0300 Subject: [PATCH 3/3] Update src/Discord.Net.Core/Entities/Guilds/IGuild.cs Co-authored-by: Armano den Boef <68127614+Rozen4334@users.noreply.github.com> --- src/Discord.Net.Core/Entities/Guilds/IGuild.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Discord.Net.Core/Entities/Guilds/IGuild.cs b/src/Discord.Net.Core/Entities/Guilds/IGuild.cs index 88255d56c..34a08f1e7 100644 --- a/src/Discord.Net.Core/Entities/Guilds/IGuild.cs +++ b/src/Discord.Net.Core/Entities/Guilds/IGuild.cs @@ -1198,7 +1198,7 @@ namespace Discord /// Whether to include full localization dictionaries in the returned objects, /// instead of the localized name and description fields. /// - /// The target locale of the localized name and description fields. Sets X-Discord-Locale header, which takes precedence over Accept-Language. + /// The target locale of the localized name and description fields. Sets the X-Discord-Locale header, which takes precedence over Accept-Language. /// The options to be used when sending the request. /// /// A task that represents the asynchronous get operation. The task result contains a read-only collection