Removes fromUserId; cleans up model creation; replaces function with individual parameters

src/Discord.Net.Rest/Entities/Messages/MessageHelper.cs

@@ -47,32 +47,25 @@ namespace Discord.Rest
         }
 
         public static IAsyncEnumerable<IReadOnlyCollection<IUser>> GetReactionUsersAsync(IMessage msg, IEmote emote,
-            Action<GetReactionUsersParams> func, BaseDiscordClient client, RequestOptions options)
+            int? limit, BaseDiscordClient client, RequestOptions options)
         {
             Preconditions.NotNull(emote, nameof(emote));
             var emoji = (emote is Emote e ? $"{e.Name}:{e.Id}" : emote.Name);
 
-            var arguments = new GetReactionUsersParams();
-            func(arguments);
-
             return new PagedAsyncEnumerable<IUser>(
                 DiscordConfig.MaxUserReactionsPerBatch,
                 async (info, ct) =>
                 {
-                    var args = new GetReactionUsersParams();
-                    func(args);
-                    args.Limit = info.PageSize;
+                    var args = new GetReactionUsersParams
+                    {
+                        Limit = info.PageSize
+                    };
 
                     if (info.Position != null)
                         args.AfterUserId = info.Position.Value;
 
                     var models = await client.ApiClient.GetReactionUsersAsync(msg.Channel.Id, msg.Id, emoji, args, options).ConfigureAwait(false);
-                    var builder = ImmutableArray.CreateBuilder<IUser>();
-
-                    foreach (var model in models)
-                        builder.Add(RestUser.Create(client, model));
-
-                    return builder.ToImmutable();
+                    return models.Select(x => RestUser.Create(client, x)).ToImmutableArray();
                 },
                 nextPage: (info, lastPage) =>
                 {
@@ -82,8 +75,7 @@ namespace Discord.Rest
                     info.Position = lastPage.Max(x => x.Id);
                     return true;
                 },
-                start: arguments.AfterUserId.IsSpecified ? arguments.AfterUserId.Value : (ulong?)null,
-                count: arguments.Limit.GetValueOrDefault(DiscordConfig.MaxUserReactionsPerBatch)
+                count: limit
             );
 
         }

src/Discord.Net.Rest/Entities/Messages/RestUserMessage.cs

@@ -137,7 +137,7 @@ namespace Discord.Rest
         public Task RemoveAllReactionsAsync(RequestOptions options = null)
             => MessageHelper.RemoveAllReactionsAsync(this, Discord, options);
         public IAsyncEnumerable<IReadOnlyCollection<IUser>> GetReactionUsersAsync(IEmote emote, int limit, RequestOptions options = null)
-            => MessageHelper.GetReactionUsersAsync(this, emote, x => { x.Limit = limit; }, Discord, options);
+            => MessageHelper.GetReactionUsersAsync(this, emote, limit, Discord, options);
 
 
         public Task PinAsync(RequestOptions options = null)

src/Discord.Net.WebSocket/Entities/Messages/SocketUserMessage.cs

@@ -131,7 +131,7 @@ namespace Discord.WebSocket
         public Task RemoveAllReactionsAsync(RequestOptions options = null)
             => MessageHelper.RemoveAllReactionsAsync(this, Discord, options);
         public IAsyncEnumerable<IReadOnlyCollection<IUser>> GetReactionUsersAsync(IEmote emote, int limit, RequestOptions options = null)
-            => MessageHelper.GetReactionUsersAsync(this, emote, x => { x.Limit = limit; }, Discord, options);
+            => MessageHelper.GetReactionUsersAsync(this, emote, limit, Discord, options);
 
         public Task PinAsync(RequestOptions options = null)
             => MessageHelper.PinAsync(this, Discord, options);