From 4197f8b2379e149e630c9512008af2a7e18f3867 Mon Sep 17 00:00:00 2001
From: Still Hsu <341464@gmail.com>
Date: Mon, 10 Sep 2018 20:08:00 +0800
Subject: [PATCH] Cleanup
https://github.com/RogueException/Discord.Net/pull/1139
---
.../Attributes/OverrideTypeReaderAttribute.cs | 2 +-
src/Discord.Net.Core/Entities/Emotes/Emote.cs | 2 +-
.../Entities/Messages/EmbedBuilder.cs | 14 +++++++-------
.../Entities/Permissions/ChannelPermissions.cs | 2 +-
src/Discord.Net.Core/Utils/MentionUtils.cs | 6 +++---
src/Discord.Net.Rest/DiscordRestApiClient.cs | 2 +-
6 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/src/Discord.Net.Commands/Attributes/OverrideTypeReaderAttribute.cs b/src/Discord.Net.Commands/Attributes/OverrideTypeReaderAttribute.cs
index fa661fb5f..ec110ab1a 100644
--- a/src/Discord.Net.Commands/Attributes/OverrideTypeReaderAttribute.cs
+++ b/src/Discord.Net.Commands/Attributes/OverrideTypeReaderAttribute.cs
@@ -23,7 +23,7 @@ namespace Discord.Commands
public OverrideTypeReaderAttribute(Type overridenTypeReader)
{
if (!TypeReaderTypeInfo.IsAssignableFrom(overridenTypeReader.GetTypeInfo()))
- throw new ArgumentException($"{nameof(overridenTypeReader)} must inherit from {nameof(TypeReader)}");
+ throw new ArgumentException($"{nameof(overridenTypeReader)} must inherit from {nameof(TypeReader)}.");
TypeReader = overridenTypeReader;
}
diff --git a/src/Discord.Net.Core/Entities/Emotes/Emote.cs b/src/Discord.Net.Core/Entities/Emotes/Emote.cs
index a59f10546..b9f166ab3 100644
--- a/src/Discord.Net.Core/Entities/Emotes/Emote.cs
+++ b/src/Discord.Net.Core/Entities/Emotes/Emote.cs
@@ -69,7 +69,7 @@ namespace Discord
{
if (TryParse(text, out Emote result))
return result;
- throw new ArgumentException(message: "Invalid emote format", paramName: nameof(text));
+ throw new ArgumentException(message: "Invalid emote format.", paramName: nameof(text));
}
/// Tries to parse an from its raw format.
diff --git a/src/Discord.Net.Core/Entities/Messages/EmbedBuilder.cs b/src/Discord.Net.Core/Entities/Messages/EmbedBuilder.cs
index 18e084aa0..39d24fa03 100644
--- a/src/Discord.Net.Core/Entities/Messages/EmbedBuilder.cs
+++ b/src/Discord.Net.Core/Entities/Messages/EmbedBuilder.cs
@@ -75,7 +75,7 @@ namespace Discord
get => _url;
set
{
- if (!value.IsNullOrUri()) throw new ArgumentException(message: "Url must be a well-formed URI", paramName: nameof(Url));
+ if (!value.IsNullOrUri()) throw new ArgumentException(message: "Url must be a well-formed URI.", paramName: nameof(Url));
_url = value;
}
}
@@ -87,7 +87,7 @@ namespace Discord
get => _thumbnail?.Url;
set
{
- if (!value.IsNullOrUri()) throw new ArgumentException(message: "Url must be a well-formed URI", paramName: nameof(ThumbnailUrl));
+ if (!value.IsNullOrUri()) throw new ArgumentException(message: "Url must be a well-formed URI.", paramName: nameof(ThumbnailUrl));
_thumbnail = new EmbedThumbnail(value, null, null, null);
}
}
@@ -99,7 +99,7 @@ namespace Discord
get => _image?.Url;
set
{
- if (!value.IsNullOrUri()) throw new ArgumentException(message: "Url must be a well-formed URI", paramName: nameof(ImageUrl));
+ if (!value.IsNullOrUri()) throw new ArgumentException(message: "Url must be a well-formed URI.", paramName: nameof(ImageUrl));
_image = new EmbedImage(value, null, null, null);
}
}
@@ -115,7 +115,7 @@ namespace Discord
get => _fields;
set
{
- if (value == null) throw new ArgumentNullException(paramName: nameof(Fields), message: "Cannot set an embed builder's fields collection to null");
+ if (value == null) throw new ArgumentNullException(paramName: nameof(Fields), message: "Cannot set an embed builder's fields collection to null.");
if (value.Count > MaxFieldCount) throw new ArgumentException(message: $"Field count must be less than or equal to {MaxFieldCount}.", paramName: nameof(Fields));
_fields = value;
}
@@ -590,7 +590,7 @@ namespace Discord
get => _url;
set
{
- if (!value.IsNullOrUri()) throw new ArgumentException(message: "Url must be a well-formed URI", paramName: nameof(Url));
+ if (!value.IsNullOrUri()) throw new ArgumentException(message: "Url must be a well-formed URI.", paramName: nameof(Url));
_url = value;
}
}
@@ -606,7 +606,7 @@ namespace Discord
get => _iconUrl;
set
{
- if (!value.IsNullOrUri()) throw new ArgumentException(message: "Url must be a well-formed URI", paramName: nameof(IconUrl));
+ if (!value.IsNullOrUri()) throw new ArgumentException(message: "Url must be a well-formed URI.", paramName: nameof(IconUrl));
_iconUrl = value;
}
}
@@ -708,7 +708,7 @@ namespace Discord
get => _iconUrl;
set
{
- if (!value.IsNullOrUri()) throw new ArgumentException(message: "Url must be a well-formed URI", paramName: nameof(IconUrl));
+ if (!value.IsNullOrUri()) throw new ArgumentException(message: "Url must be a well-formed URI.", paramName: nameof(IconUrl));
_iconUrl = value;
}
}
diff --git a/src/Discord.Net.Core/Entities/Permissions/ChannelPermissions.cs b/src/Discord.Net.Core/Entities/Permissions/ChannelPermissions.cs
index c6454c528..7bef3251a 100644
--- a/src/Discord.Net.Core/Entities/Permissions/ChannelPermissions.cs
+++ b/src/Discord.Net.Core/Entities/Permissions/ChannelPermissions.cs
@@ -31,7 +31,7 @@ namespace Discord
case ICategoryChannel _: return Category;
case IDMChannel _: return DM;
case IGroupChannel _: return Group;
- default: throw new ArgumentException(message: "Unknown channel type", paramName: nameof(channel));
+ default: throw new ArgumentException(message: "Unknown channel type.", paramName: nameof(channel));
}
}
diff --git a/src/Discord.Net.Core/Utils/MentionUtils.cs b/src/Discord.Net.Core/Utils/MentionUtils.cs
index 051044abc..6ffb7eee6 100644
--- a/src/Discord.Net.Core/Utils/MentionUtils.cs
+++ b/src/Discord.Net.Core/Utils/MentionUtils.cs
@@ -45,7 +45,7 @@ namespace Discord
{
if (TryParseUser(text, out ulong id))
return id;
- throw new ArgumentException(message: "Invalid mention format", paramName: nameof(text));
+ throw new ArgumentException(message: "Invalid mention format.", paramName: nameof(text));
}
///
/// Tries to parse a provided user mention string.
@@ -74,7 +74,7 @@ namespace Discord
{
if (TryParseChannel(text, out ulong id))
return id;
- throw new ArgumentException(message: "Invalid mention format", paramName: nameof(text));
+ throw new ArgumentException(message: "Invalid mention format.", paramName: nameof(text));
}
///
/// Tries to parse a provided channel mention string.
@@ -100,7 +100,7 @@ namespace Discord
{
if (TryParseRole(text, out ulong id))
return id;
- throw new ArgumentException(message: "Invalid mention format", paramName: nameof(text));
+ throw new ArgumentException(message: "Invalid mention format.", paramName: nameof(text));
}
///
/// Tries to parse a provided role mention string.
diff --git a/src/Discord.Net.Rest/DiscordRestApiClient.cs b/src/Discord.Net.Rest/DiscordRestApiClient.cs
index 83803b282..6e80f2c81 100644
--- a/src/Discord.Net.Rest/DiscordRestApiClient.cs
+++ b/src/Discord.Net.Rest/DiscordRestApiClient.cs
@@ -82,7 +82,7 @@ namespace Discord.API
case TokenType.Bearer:
return $"Bearer {token}";
default:
- throw new ArgumentException(message: "Unknown OAuth token type", paramName: nameof(tokenType));
+ throw new ArgumentException(message: "Unknown OAuth token type.", paramName: nameof(tokenType));
}
}
internal virtual void Dispose(bool disposing)