From 0e8fbe09ccc9df835d326c191069261614d65a7f Mon Sep 17 00:00:00 2001 From: Still Hsu <341464@gmail.com> Date: Sun, 23 Dec 2018 20:42:21 +0800 Subject: [PATCH] Update according to PR suggestions * Reword sentences of deployment article for clarification & remove mention of portability * Fix typos/grammar errors within TextChannelProperties --- docs/guides/commands/post-execution.md | 5 ++--- docs/guides/deployment/deployment.md | 10 +++++----- .../Entities/Channels/TextChannelProperties.cs | 6 +++--- 3 files changed, 10 insertions(+), 11 deletions(-) diff --git a/docs/guides/commands/post-execution.md b/docs/guides/commands/post-execution.md index bce29141f..782d256b2 100644 --- a/docs/guides/commands/post-execution.md +++ b/docs/guides/commands/post-execution.md @@ -38,9 +38,8 @@ about the impact in @FAQ.Commands.General. Enter [CommandExecuted], an event that was introduced in Discord.Net 2.0. This event is raised whenever a command is executed regardless of its execution status. This means this -event can be used to streamline your post-execution design, and the -best thing about this event is that it is not prone -to `RunMode.Async`'s [ExecuteAsync] drawbacks. +event can be used to streamline your post-execution design, +is not prone to `RunMode.Async`'s [ExecuteAsync] drawbacks. Thus, we can begin working on code such as: diff --git a/docs/guides/deployment/deployment.md b/docs/guides/deployment/deployment.md index e11a56932..0491e841d 100644 --- a/docs/guides/deployment/deployment.md +++ b/docs/guides/deployment/deployment.md @@ -59,7 +59,7 @@ When redistributing the application - whether for deployment on a remote machine or for sharing with another user - you may want to publish the application; in other words, to create a self-contained package without installing the dependencies -and the runtime on the target machine. +and the runtime on the target platform. ### Framework-dependent Deployment @@ -76,7 +76,8 @@ program. > [!TIP] > Do not know how to run a .NET Core application with -> the `dotnet` runtime? Navigate to the folder of the program and +> the `dotnet` runtime? Navigate to the folder of the program +> (typically under `$projFolder/bin/Release`) and > enter `dotnet program.dll` where `program.dll` is your compiled > binaries. @@ -89,9 +90,8 @@ machine without the `dotnet` runtime), publish with a specific This will create a package with dependencies compiled for the target platform, meaning that all the required dependencies will be included with the program. This will result in **larger package size**; -however, not only is the portabilitiy greatly increased, but also the -it will include a copy of the executable that can be run -natively on the target runtime. +however, that means the copy of the runtime that can be run +natively on the target platform. For example, the following command will create a Windows executable (`.exe`) that is ready to be executed on any diff --git a/src/Discord.Net.Core/Entities/Channels/TextChannelProperties.cs b/src/Discord.Net.Core/Entities/Channels/TextChannelProperties.cs index c9d0ba1d6..6dcbf860a 100644 --- a/src/Discord.Net.Core/Entities/Channels/TextChannelProperties.cs +++ b/src/Discord.Net.Core/Entities/Channels/TextChannelProperties.cs @@ -21,15 +21,15 @@ namespace Discord /// /// /// Setting this value to true will mark the channel as NSFW (Not Safe For Work) and will prompt the - /// user about its maturity nature before they may view the channel; setting this value to false will - /// mark this channel as SFW (Safe For Work). + /// user about its possibly mature nature before they may view the channel; setting this value to false will + /// remove the NSFW indicator. /// public Optional IsNsfw { get; set; } /// /// Gets or sets the slow-mode ratelimit in seconds for this channel. /// /// - /// Setting this value to anything above zero will require each user to wait X amount of second before + /// Setting this value to anything above zero will require each user to wait X seconds before /// sending another message; setting this value to 0 will disable slow-mode for this channel. /// /// Users with or