git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@278328 13f79535-47bb-0310-9956-ffa450edef68master
| @@ -523,13 +523,8 @@ public class Concat extends Task { | |||||
| in = null; | in = null; | ||||
| } | } | ||||
| } finally { | } finally { | ||||
| if (in != null) { | |||||
| try { | |||||
| in.close(); | |||||
| } catch (Throwable t) { | |||||
| // Ignore | |||||
| } | |||||
| } | |||||
| FileUtils.close(in); | |||||
| if (out != null) { | if (out != null) { | ||||
| try { | try { | ||||
| out.close(); | out.close(); | ||||
| @@ -730,13 +725,7 @@ public class Concat extends Task { | |||||
| } catch (IOException ex) { | } catch (IOException ex) { | ||||
| throw new BuildException(ex); | throw new BuildException(ex); | ||||
| } finally { | } finally { | ||||
| if (reader != null) { | |||||
| try { | |||||
| reader.close(); | |||||
| } catch (Throwable t) { | |||||
| // ignore | |||||
| } | |||||
| } | |||||
| FileUtils.close(reader); | |||||
| } | } | ||||
| } | } | ||||
| @@ -21,8 +21,10 @@ import java.io.FileWriter; | |||||
| import java.io.IOException; | import java.io.IOException; | ||||
| import java.io.PrintWriter; | import java.io.PrintWriter; | ||||
| import java.util.Random; | import java.util.Random; | ||||
| import org.apache.tools.ant.BuildException; | import org.apache.tools.ant.BuildException; | ||||
| import org.apache.tools.ant.Project; | import org.apache.tools.ant.Project; | ||||
| import org.apache.tools.ant.util.FileUtils; | |||||
| /** | /** | ||||
| * Encapsulates a Jikes compiler, by directly executing an external | * Encapsulates a Jikes compiler, by directly executing an external | ||||
| @@ -94,13 +96,7 @@ public class Jikes { | |||||
| throw new BuildException("Error creating temporary file", | throw new BuildException("Error creating temporary file", | ||||
| e); | e); | ||||
| } finally { | } finally { | ||||
| if (out != null) { | |||||
| try { | |||||
| out.close(); | |||||
| } catch (Throwable t) { | |||||
| // ignore | |||||
| } | |||||
| } | |||||
| FileUtils.close(out); | |||||
| } | } | ||||
| } else { | } else { | ||||
| commandArray = new String[args.length + 1]; | commandArray = new String[args.length + 1]; | ||||
| @@ -37,6 +37,7 @@ import org.apache.tools.ant.types.EnumeratedAttribute; | |||||
| import org.apache.tools.ant.types.Path; | import org.apache.tools.ant.types.Path; | ||||
| import org.apache.tools.ant.types.PatternSet; | import org.apache.tools.ant.types.PatternSet; | ||||
| import org.apache.tools.ant.types.Reference; | import org.apache.tools.ant.types.Reference; | ||||
| import org.apache.tools.ant.util.FileUtils; | |||||
| import org.apache.tools.ant.util.LoaderUtils; | import org.apache.tools.ant.util.LoaderUtils; | ||||
| /** | /** | ||||
| @@ -551,13 +552,7 @@ public class JDependTask extends Task { | |||||
| jdepend.analyze(); | jdepend.analyze(); | ||||
| } finally { | } finally { | ||||
| if (fw != null) { | |||||
| try { | |||||
| fw.close(); | |||||
| } catch (Throwable t) { | |||||
| // Ignore | |||||
| } | |||||
| } | |||||
| FileUtils.close(fw); | |||||
| } | } | ||||
| return SUCCESS; | return SUCCESS; | ||||
| } | } | ||||
| @@ -71,7 +71,7 @@ public class DynamicFilterTest extends BuildFileTest { | |||||
| return FileUtils.readFully(r); | return FileUtils.readFully(r); | ||||
| } | } | ||||
| finally { | finally { | ||||
| try {r.close();} catch (Throwable ignore) {} | |||||
| FileUtils.close(r); | |||||
| } | } | ||||
| } | } | ||||
| @@ -251,7 +251,7 @@ public class TokenFilterTest extends BuildFileTest { | |||||
| return FileUtils.readFully(r); | return FileUtils.readFully(r); | ||||
| } | } | ||||
| finally { | finally { | ||||
| try {r.close();} catch (Throwable ignore) {} | |||||
| FileUtils.close(r); | |||||
| } | } | ||||
| } | } | ||||
| @@ -246,7 +246,7 @@ public class ConcatTest | |||||
| return FileUtils.readFully(r); | return FileUtils.readFully(r); | ||||
| } | } | ||||
| finally { | finally { | ||||
| try {r.close();} catch (Throwable ignore) {} | |||||
| FileUtils.close(r); | |||||
| } | } | ||||
| } | } | ||||
| @@ -482,12 +482,7 @@ public class ExecTaskTest extends BuildFileTest { | |||||
| result = FileUtils.readFully(reader); | result = FileUtils.readFully(reader); | ||||
| } catch (IOException eyeOhEx) { | } catch (IOException eyeOhEx) { | ||||
| } finally { | } finally { | ||||
| if (reader != null) { | |||||
| try { | |||||
| reader.close(); | |||||
| } catch (Throwable ignore) { | |||||
| } | |||||
| } | |||||
| FileUtils.close(reader); | |||||
| } | } | ||||
| return result; | return result; | ||||
| } | } | ||||
| @@ -570,12 +570,7 @@ public class ExecuteOnTest extends BuildFileTest { | |||||
| reader = new FileReader(getProject().resolveFile(filename)); | reader = new FileReader(getProject().resolveFile(filename)); | ||||
| result = FileUtils.readFully(reader); | result = FileUtils.readFully(reader); | ||||
| } finally { | } finally { | ||||
| if (reader != null) { | |||||
| try { | |||||
| reader.close(); | |||||
| } catch (Throwable ignore) { | |||||
| } | |||||
| } | |||||
| FileUtils.close(reader); | |||||
| } | } | ||||
| return result; | return result; | ||||
| } | } | ||||
| @@ -124,7 +124,7 @@ public class StyleTest extends BuildFileTest { | |||||
| return FileUtils.readFully(r); | return FileUtils.readFully(r); | ||||
| } | } | ||||
| finally { | finally { | ||||
| try {r.close();} catch (Throwable ignore) {} | |||||
| FileUtils.close(r); | |||||
| } | } | ||||
| } | } | ||||