making the exec task fast again, using the patch provided by Tim Whittington, Bugzilla PR 54128

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@1551113 13f79535-47bb-0310-9956-ffa450edef68

CONTRIBUTORS

@@ -358,6 +358,7 @@ Thomas Quas
 Tim Drury
 Tim Fennell
 Tim Stephenson
+Tim Whittington
 Timoteo Ohara
 Timothy Gerard Endres
 Tom Ball

WHATSNEW

@@ -22,6 +22,9 @@ Fixed bugs:
    made macrodef fail.
    Bugzilla Report 55885.
 
+ * Ant 1.8 exec task changes have slowed exec to a crawl
+   Bugzilla Report 54128.
+
 Other changes:
 --------------
 

contributors.xml

@@ -1435,6 +1435,10 @@
     <first>Tim</first>
     <last>Fennell</last>
   </name>
+  <name>
+    <first>Tim</first>
+    <last>Whittington</last>
+  </name>
   <name>
     <first>Timoteo</first>
     <last>Ohara</last>

src/main/org/apache/tools/ant/taskdefs/PumpStreamHandler.java

@@ -185,10 +185,10 @@ public class PumpStreamHandler implements ExecuteStreamHandler {
                 return;
             }
 
-            t.join(JOIN_TIMEOUT);
             if (s != null && !s.isFinished()) {
                 s.stop();
             }
+            t.join(JOIN_TIMEOUT);
             while ((s == null || !s.isFinished()) && t.isAlive()) {
                 t.interrupt();
                 t.join(JOIN_TIMEOUT);

src/main/org/apache/tools/ant/taskdefs/StreamPumper.java

@@ -116,7 +116,6 @@ public class StreamPumper implements Runnable {
             started = true;
         }
         finished = false;
-        finish = false;
 
         final byte[] buf = new byte[bufferSize];
 
@@ -130,13 +129,29 @@ public class StreamPumper implements Runnable {
                 }
 
                 length = is.read(buf);
-                if (length <= 0 || finish || Thread.interrupted()) {
+                if (length <= 0 || Thread.interrupted()) {
                     break;
                 }
                 os.write(buf, 0, length);
                 if (autoflush) {
                     os.flush();
                 }
+                if (finish) {
+                	break;
+                }
+            }
+            // On completion, drain any available data (which might be the first data available for quick executions)
+            if (finish) {
+                while((length = is.available()) > 0) {
+                	if (Thread.interrupted()) {
+                		break;
+                	}
+                    length = is.read(buf, 0, Math.min(length, buf.length));
+                    if (length <= 0) {
+                        break;
+                    }
+                    os.write(buf, 0, length);
+                }
             }
             os.flush();
         } catch (InterruptedException ie) {
@@ -150,6 +165,7 @@ public class StreamPumper implements Runnable {
                 FileUtils.close(os);
             }
             finished = true;
+            finish = false;
             synchronized (this) {
                 notifyAll();
             }