Performance:

* Use arrayCopy
* Avoid redundant String.format
* Exit the loop early

CONTRIBUTORS

@@ -36,6 +36,7 @@ Arcadius Ahouansou
 Arjan Veenstra
 Arnaud Vandyck
 Arnout J. Kuiper
+Arturo Bernal
 Arun Jamwal
 Aslak Hellesôy
 Atsuhiko Yamanaka

contributors.xml

@@ -172,6 +172,10 @@
     <middle>J.</middle>
     <last>Kuiper</last>
   </name>
+  <name>
+    <first>Arturo</first>
+    <last>Bernal</last>
+  </name>
   <name>
     <first>Arun</first>
     <last>Jamwal</last>

src/main/org/apache/tools/ant/NoBannerLogger.java

@@ -88,7 +88,7 @@ public class NoBannerLogger extends DefaultLogger {
 
         synchronized (this) {
             if (null != targetName) {
-                out.println(String.format("%n%s:", targetName));
+                out.printf("%n%s:%n", targetName);
                 targetName = null;
             }
         }

src/main/org/apache/tools/ant/taskdefs/RecorderEntry.java

@@ -107,9 +107,9 @@ public class RecorderEntry implements BuildLogger, SubBuildListener {
             Throwable error = event.getException();
 
             if (error == null) {
-                out.println(String.format("%nBUILD SUCCESSFUL"));
+                out.printf("%nBUILD SUCCESSFUL%n");
             } else {
-                out.println(String.format("%nBUILD FAILED%n"));
+                out.printf("%nBUILD FAILED%n%n");
                 error.printStackTrace(out); //NOSONAR
             }
         }

src/main/org/apache/tools/ant/taskdefs/compilers/JavacExternal.java

@@ -94,8 +94,8 @@ public class JavacExternal extends DefaultCompilerAdapter {
         for(int i = nonArgFileOptionIdx + 1; i < commandLine.length; i++) {
             if (!isArgFileEligible(commandLine[i])) {
                 String option = commandLine[i];
-                for(int j = i - 1; j >= nonArgFileOptionIdx; j--) {
-                    commandLine[j + 1] = commandLine[j];
+                if (i - nonArgFileOptionIdx >= 0) {
+                    System.arraycopy( commandLine, nonArgFileOptionIdx, commandLine, nonArgFileOptionIdx + 1, i - nonArgFileOptionIdx );
                 }
                 commandLine[nonArgFileOptionIdx] = option;
                 nonArgFileOptionIdx++;

src/main/org/apache/tools/bzip2/CBZip2OutputStream.java

@@ -1210,6 +1210,7 @@ public class CBZip2OutputStream extends OutputStream
             for (int j = 16; --j >= 0;) {
                 if (inUse[i16 + j]) {
                     inUse16[i] = true;
+                    break;
                 }
             }
         }