diff --git a/WHATSNEW b/WHATSNEW index d9f2fb3af..0d1254dcd 100644 --- a/WHATSNEW +++ b/WHATSNEW @@ -415,6 +415,11 @@ Fixed bugs: * AntClassLoader didn't set the proper CodeSource for loaded classes. Bugzilla Report 20174. + * AntClassLoader.getResourceAsStream would return streams to + resources it didn't return with getResource and to classes it + failed to load. + Bugzilla Report 44103. + Other changes: -------------- * The get task now also follows redirects from http to https diff --git a/src/main/org/apache/tools/ant/AntClassLoader.java b/src/main/org/apache/tools/ant/AntClassLoader.java index f921b039b..7cc0e2091 100644 --- a/src/main/org/apache/tools/ant/AntClassLoader.java +++ b/src/main/org/apache/tools/ant/AntClassLoader.java @@ -705,6 +705,7 @@ public class AntClassLoader extends ClassLoader implements SubBuildListener { InputStream resourceStream = null; if (isParentFirst(name)) { resourceStream = loadBaseResource(name); + } if (resourceStream != null) { log("ResourceStream for " + name + " loaded from parent loader", Project.MSG_DEBUG); @@ -715,17 +716,16 @@ public class AntClassLoader extends ClassLoader implements SubBuildListener { + " loaded from ant loader", Project.MSG_DEBUG); } } - } else { - resourceStream = loadResource(name); - if (resourceStream != null) { - log("ResourceStream for " + name + " loaded from ant loader", Project.MSG_DEBUG); + if (resourceStream == null && !isParentFirst(name)) { + if (ignoreBase) { + resourceStream = getRootLoader() == null ? null : getRootLoader().getResourceAsStream(name); } else { resourceStream = loadBaseResource(name); + } if (resourceStream != null) { log("ResourceStream for " + name + " loaded from parent loader", Project.MSG_DEBUG); } - } } if (resourceStream == null) { log("Couldn't load ResourceStream for " + name, Project.MSG_DEBUG); @@ -766,7 +766,7 @@ public class AntClassLoader extends ClassLoader implements SubBuildListener { * the resource cannot be found. */ private InputStream loadBaseResource(String name) { - return parent == null ? getSystemResourceAsStream(name) : parent.getResourceAsStream(name); + return parent == null ? super.getResourceAsStream(name) : parent.getResourceAsStream(name); } /** diff --git a/src/tests/antunit/core/classloader-test.xml b/src/tests/antunit/core/classloader-test.xml new file mode 100644 index 000000000..61df41cb4 --- /dev/null +++ b/src/tests/antunit/core/classloader-test.xml @@ -0,0 +1,83 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +