From 09e0f524e69e6ccb1fd242633fa885f54a3c3191 Mon Sep 17 00:00:00 2001 From: Stefan Bodewig Date: Tue, 17 Jun 2008 11:58:55 +0000 Subject: [PATCH] Re-order, don't even enter the try block if there is nothing to do git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@668625 13f79535-47bb-0310-9956-ffa450edef68 --- src/main/org/apache/tools/ant/taskdefs/Definer.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main/org/apache/tools/ant/taskdefs/Definer.java b/src/main/org/apache/tools/ant/taskdefs/Definer.java index 14642a037..b360aa219 100644 --- a/src/main/org/apache/tools/ant/taskdefs/Definer.java +++ b/src/main/org/apache/tools/ant/taskdefs/Definer.java @@ -340,15 +340,15 @@ public abstract class Definer extends DefBase { if (message == null && !(file.isFile())) { message = "File " + file + " is not a file"; } - try { if (message == null) { + try { return FileUtils.getFileUtils().getFileURL(file); - } } catch (Exception ex) { message = "File " + file + " cannot use as URL: " + ex.toString(); } + } // Here if there is an error switch (onError) { case OnError.FAIL_ALL: