You can not select more than 25 topics Topics must start with a chinese character,a letter or number, can include dashes ('-') and can be up to 35 characters long.

CONTRIBUTING.md 2.5 kB

12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849505152535455
  1. Contributing to Apache Ant
  2. ==========================
  3. You have found a bug or think you know how to code a great feature
  4. that all other people could benefit from? This is great, we'd love to
  5. hear from you.
  6. Ant's primary code repository is the
  7. [git repository at Apache](https://git-wip-us.apache.org/repos/asf/ant.git)
  8. and we've also got a [github mirror](https://github.com/apache/ant/).
  9. There are two ways you can contribute, you can either use the
  10. "traditional" approach of creating a patch and attaching it to a
  11. Bugzilla issue or you use a github pull request. We do not plan to
  12. use github issues, so if you are reporting a bug, please raise a
  13. [Bugzilla issue](https://issues.apache.org/bugzilla/).
  14. Before reporting a bug, please also review http://ant.apache.org/problems.html
  15. If you're planning to implement a new feature please discuss you're
  16. changes on the
  17. [dev list](http://ant.apache.org/mail.html#Developer%20List:%20dev@ant.apache.org)
  18. first. This way you can make sure you're not wasting your time on
  19. something that isn't considered to be in Ant's scope.
  20. Making Changes
  21. --------------
  22. + Create a topic branch from where you want to base your work (this is
  23. usually the master branch).
  24. + Make commits of logical units.
  25. + Respect the original code style:
  26. + Only use spaces for indentation.
  27. + Create minimal diffs - disable on save actions like reformat
  28. source code or organize imports. If you feel the source code
  29. should be reformatted create a separate issue/PR for this change.
  30. + Check for unnecessary whitespace with `git diff --check` before committing.
  31. + Make sure your commit messages are in the proper format. Your commit
  32. message should contain the key of the Bugzilla issue if you created one.
  33. + Make sure you have added the necessary tests for your changes.
  34. + Run all the tests with `./build.sh clean test` to assure nothing
  35. else was accidentally broken.
  36. Submitting Changes
  37. ------------------
  38. + Sign the [Contributor License Agreement][cla] unless your change is
  39. really small or you have already signed one.
  40. + If you want to create a patch for your Bugzilla issue use `git
  41. format-patch` to create it (or a set of patches), this way we can
  42. keep your author information. Attach the patch(es) to the issue.
  43. + Alternatively push your changes to a topic branch in your fork of the repository.
  44. + Submit a pull request to the repository in the apache organization.
  45. [cla]:http://www.apache.org/licenses/#clas