aiforge

346 MB

Tree: 18a49720bc

Author	SHA1	Message	Date
mrsdizzie	b647d54e0d	Clean up various use of escape/unescape functions for URL generation (#6334 ) * Use PathUnescape instead of QueryUnescape when working with branch names Currently branch names with a '+' fail in certain situations because QueryUnescape replaces the + character with a blank space. Using PathUnescape should be better since it is defined as: // PathUnescape is identical to QueryUnescape except that it does not // unescape '+' to ' ' (space). Fixes #6333 * Change error to match new function name * Add new util function PathEscapeSegments This function simply runs PathEscape on each segment of a path without touching the forward slash itself. We want to use this instead of PathEscape/QueryEscape in most cases because a forward slash is a valid name for a branch etc... and we don't want that escaped in a URL. Putting this in new file url.go and also moving a couple similar functions into that file as well. * Use EscapePathSegments where appropriate Replace various uses of EscapePath/EscapeQuery with new EscapePathSegments. Also remove uncessary uses of various escape/unescape functions when the text had already been escaped or was not escaped. * Reformat comment to make drone build happy * Remove no longer used url library * Requested code changes	6 years ago
Ethan Koenig	61265d6037	Use httptest in integration tests (#3080 )	8 years ago
Lunny Xiao	1c80057b53	improve protected branch to add whitelist support (#2451 ) * improve protected branch to add whitelist support * fix lint * fix style check * fix tests * fix description on UI and import * fix test * bug fixed * fix tests and languages * move isSliceInt64Eq to util pkg; improve function names & typo	8 years ago
Ethan Koenig	1c10f454eb	Less verbose integration tests (#2123 ) * Helper functions for intergration test boilerplate	8 years ago
Ethan Koenig	e4e3367ae7	Display URLs in integration test logs (#1924 )	8 years ago
Lunny Xiao	325386b558	fix bug when push a branch name with / & fix an integration test bug (#1689 )	8 years ago

6 Commits (18a49720bced9c8fe08fa7cf0125765501b51e65)