Browse Source

Always return a list from GetCommitsFromIDs (#12981)

`GetCommitsFromIDs` is only used in one place: `LoadPushCommits` where
it expects that `c.Commits` is not nil.

This potentially nil set causes a NPE in in #12953

Fix #12953

Signed-off-by: Andrew Thornton <art27@cantab.net>
tags/v1.13.0-rc1
zeripath GitHub 5 years ago
parent
commit
757f4ed063
1 changed files with 0 additions and 4 deletions
  1. +0
    -4
      modules/git/repo_commit.go

+ 0
- 4
modules/git/repo_commit.go View File

@@ -504,10 +504,6 @@ func (repo *Repository) getBranches(commit *Commit, limit int) ([]string, error)

// GetCommitsFromIDs get commits from commit IDs
func (repo *Repository) GetCommitsFromIDs(commitIDs []string) (commits *list.List) {
if len(commitIDs) == 0 {
return nil
}

commits = list.New()

for _, commitID := range commitIDs {


Loading…
Cancel
Save