Browse Source

Fix comment triangles and tweak inline comment margins (#13554)

- Fix various miscolored comment bubble triangles
- Tweak padding on inline comment boxes
tags/v1.15.0-dev
silverwind GitHub 4 years ago
parent
commit
49e4eae397
3 changed files with 18 additions and 46 deletions
  1. +9
    -6
      web_src/less/_repository.less
  2. +5
    -1
      web_src/less/_review.less
  3. +4
    -39
      web_src/less/themes/theme-arc-green.less

+ 9
- 6
web_src/less/_repository.less View File

@@ -523,12 +523,12 @@
position: relative; position: relative;
padding: 15px; padding: 15px;
margin-bottom: 10px; margin-bottom: 10px;
border: 1px solid #dddddd;
border: 1px solid var(--color-secondary);
border-radius: 3px; border-radius: 3px;
#avatar-arrow; #avatar-arrow;


&::after { &::after {
border-right-color: #ffffff;
border-right-color: var(--color-box-header);
} }


.quick-pull-choice { .quick-pull-choice {
@@ -598,7 +598,7 @@
#avatar-arrow; #avatar-arrow;


&::after { &::after {
border-right-color: #ffffff;
border-right-color: var(--color-box-body);
} }


.markdown { .markdown {
@@ -1024,6 +1024,10 @@


&.no-header { &.no-header {
#avatar-arrow; #avatar-arrow;

&::after {
border-right-color: var(--color-box-body);
}
} }


@media only screen and (max-width: 767px) { @media only screen and (max-width: 767px) {
@@ -1221,7 +1225,7 @@
#avatar-arrow; #avatar-arrow;


&::after { &::after {
border-right-color: #ffffff;
border-right-color: var(--color-box-body);
} }
} }


@@ -1361,7 +1365,7 @@
#avatar-arrow; #avatar-arrow;


&::after { &::after {
border-right-color: #ffffff;
border-right-color: var(--color-box-body);
} }
} }
} }
@@ -2915,7 +2919,6 @@
} }


#avatar-arrow { #avatar-arrow {

&::before, &::before,
&::after { &::after {
right: 100%; right: 100%;


+ 5
- 1
web_src/less/_review.less View File

@@ -42,11 +42,15 @@
} }


.comment-code-cloud { .comment-code-cloud {
padding: 4px;
padding: .5rem;
padding-left: 0; padding-left: 0;
position: relative; position: relative;
margin: 0 auto; margin: 0 auto;


.comments .comment {
margin: 0;
}

.attached { .attached {
&.tab { &.tab {
border: 0; border: 0;


+ 4
- 39
web_src/less/themes/theme-arc-green.less View File

@@ -1036,28 +1036,10 @@ a.ui.basic.green.label:hover {
color: #dbdbdb !important; color: #dbdbdb !important;
} }


.repository.view.issue .comment-list .comment .content {
.header {
color: #dbdbdb;
background-color: var(--color-secondary);
border-color: var(--color-secondary);
}

.header::after {
border-right-color: var(--color-secondary);
}

.merge-section.no-header::after {
border-right-color: var(--color-secondary);
}

.header::before {
border-right-color: var(--color-secondary);
}

.merge-section.no-header::before {
border-right-color: #505667;
}
.repository.view.issue .comment-list .comment .content .header {
color: #dbdbdb;
background-color: var(--color-secondary);
border-color: var(--color-secondary);
} }


.repository.view.issue .comment-list .timeline-item .badge { .repository.view.issue .comment-list .timeline-item .badge {
@@ -1072,23 +1054,6 @@ a.ui.basic.green.label:hover {
color: #dedede; color: #dedede;
} }


.repository.file.editor .commit-form-wrapper .commit-form {
border-color: #505667;
}

.repository.file.editor .commit-form-wrapper .commit-form::before,
.repository.file.editor .commit-form-wrapper .commit-form::after {
border-right-color: #505667;
}

.repository .comment.form .content .form::after {
border-right-color: #353945;
}

.repository .comment.form .content .form::before {
border-right-color: var(--color-secondary);
}

.repository .comment.form .ui.tabular.menu .item.active { .repository .comment.form .ui.tabular.menu .item.active {
background: #353945; background: #353945;
} }


Loading…
Cancel
Save