From 3b1601ae7e464ba6834c3c7c480c9b698d9dd849 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alberto=20Gonz=C3=A1lez=20Palomo?= Date: Sun, 7 Jan 2018 13:11:17 +0100 Subject: [PATCH] Ensure docs makefile downloads theme if failed before. (#3322) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The makefile did not download the theme if the directory "themes/gitea" is there, even if empty. On a fresh Ubuntu install, curl is not included, so the theme rule fails just after creating the empty directory. When you try again after installing curl, the rule is not triggered. This could also happen if the download fails for other reasons. This change makes the theme rule depend on the file "theme.toml" which will be there only after unpacking a successfully downloaded theme archive. Signed-off-by: Alberto González Palomo --- docs/Makefile | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/docs/Makefile b/docs/Makefile index e5f8d9c6e..78de2d396 100644 --- a/docs/Makefile +++ b/docs/Makefile @@ -24,6 +24,7 @@ build: $(THEME) .PHONY: update update: $(THEME) -$(THEME): - mkdir -p $@ - curl -s $(ARCHIVE) | tar xz -C $@ +$(THEME): $(THEME)/theme.toml +$(THEME)/theme.toml: + mkdir -p $$(dirname $@) + curl -s $(ARCHIVE) | tar xz -C $$(dirname $@)