You can not select more than 25 topics Topics must start with a chinese character,a letter or number, can include dashes ('-') and can be up to 35 characters long.

migrations.go 34 kB

10 years ago
Oauth2 consumer (#679) * initial stuff for oauth2 login, fails on: * login button on the signIn page to start the OAuth2 flow and a callback for each provider Only GitHub is implemented for now * show login button only when the OAuth2 consumer is configured (and activated) * create macaron group for oauth2 urls * prevent net/http in modules (other then oauth2) * use a new data sessions oauth2 folder for storing the oauth2 session data * add missing 2FA when this is enabled on the user * add password option for OAuth2 user , for use with git over http and login to the GUI * add tip for registering a GitHub OAuth application * at startup of Gitea register all configured providers and also on adding/deleting of new providers * custom handling of errors in oauth2 request init + show better tip * add ExternalLoginUser model and migration script to add it to database * link a external account to an existing account (still need to handle wrong login and signup) and remove if user is removed * remove the linked external account from the user his settings * if user is unknown we allow him to register a new account or link it to some existing account * sign up with button on signin page (als change OAuth2Provider structure so we can store basic stuff about providers) * from gorilla/sessions docs: "Important Note: If you aren't using gorilla/mux, you need to wrap your handlers with context.ClearHandler as or else you will leak memory!" (we're using gorilla/sessions for storing oauth2 sessions) * use updated goth lib that now supports getting the OAuth2 user if the AccessToken is still valid instead of re-authenticating (prevent flooding the OAuth2 provider)
8 years ago
Feature: Timetracking (#2211) * Added comment's hashtag to url for mail notifications. * Added explanation to return statement + documentation. * Replacing in-line link generation with HTMLURL. (+gofmt) * Replaced action-based model with nil-based model. (+gofmt) * Replaced mailIssueActionToParticipants with mailIssueCommentToParticipants. * Updating comment for mailIssueCommentToParticipants * Added link to comment in "Dashboard" * Deleting feed entry if a comment is going to be deleted * Added migration * Added improved migration to add a CommentID column to action. * Added improved links to comments in feed entries. * Fixes #1956 by filtering for deleted comments that are referenced in actions. * Introducing "IsDeleted" column to action. * Adding design draft (not functional) * Adding database models for stopwatches and trackedtimes * See go-gitea/gitea#967 * Adding design draft (not functional) * Adding translations and improving design * Implementing stopwatch (for timetracking) * Make UI functional * Add hints in timeline for time tracking events * Implementing timetracking feature * Adding "Add time manual" option * Improved stopwatch * Created report of total spent time by user * Only showing total time spent if theire is something to show. * Adding license headers. * Improved error handling for "Add Time Manual" * Adding @sapks 's changes, refactoring * Adding API for feature tracking * Adding unit test * Adding DISABLE/ENABLE option to Repository settings page * Improving translations * Applying @sapk 's changes * Removing repo_unit and using IssuesSetting for disabling/enabling timetracker * Adding DEFAULT_ENABLE_TIMETRACKER to config, installation and admin menu * Improving documentation * Fixing vendor/ folder * Changing timtracking routes by adding subgroups /times and /times/stopwatch (Proposed by @lafriks ) * Restricting write access to timetracking based on the repo settings (Proposed by @lafriks ) * Fixed minor permissions bug. * Adding CanUseTimetracker and IsTimetrackerEnabled in ctx.Repo * Allow assignees and authors to track there time too. * Fixed some build-time-errors + logical errors. * Removing unused Get...ByID functions * Moving IsTimetrackerEnabled from context.Repository to models.Repository * Adding a seperate file for issue related repo functions * Adding license headers * Fixed GetUserByParams return 404 * Moving /users/:username/times to /repos/:username/:reponame/times/:username for security reasons * Adding /repos/:username/times to get all tracked times of the repo * Updating sdk-dependency * Updating swagger.v1.json * Adding warning if user has already a running stopwatch (auto-timetracker) * Replacing GetTrackedTimesBy... with GetTrackedTimes(options FindTrackedTimesOptions) * Changing code.gitea.io/sdk back to code.gitea.io/sdk * Correcting spelling mistake * Updating vendor.json * Changing GET stopwatch/toggle to POST stopwatch/toggle * Changing GET stopwatch/cancel to POST stopwatch/cancel * Added migration for stopwatches/timetracking * Fixed some access bugs for read-only users * Added default allow only contributors to track time value to config * Fixed migration by chaging x.Iterate to x.Find * Resorted imports * Moved Add Time Manually form to repo_form.go * Removed "Seconds" field from Add Time Manually * Resorted imports * Improved permission checking * Fixed some bugs * Added integration test * gofmt * Adding integration test by @lafriks * Added created_unix to comment fixtures * Using last event instead of a fixed event * Adding another integration test by @lafriks * Fixing bug Timetracker enabled causing error 500 at sidebar.tpl * Fixed a refactoring bug that resulted in hiding "HasUserStopwatch" warning. * Returning TrackedTime instead of AddTimeOption at AddTime. * Updating SDK from go-gitea/go-sdk#69 * Resetting Go-SDK back to default repository * Fixing test-vendor by changing ini back to original repository * Adding "tags" to swagger spec * govendor sync * Removed duplicate * Formatting templates * Adding IsTimetrackingEnabled checks to API * Improving translations / english texts * Improving documentation * Updating swagger spec * Fixing integration test caused be translation-changes * Removed encoding issues in local_en-US.ini. * "Added" copyright line * Moved unit.IssuesConfig().EnableTimetracker into a != nil check * Removed some other encoding issues in local_en-US.ini * Improved javascript by checking if data-context exists * Replaced manual comment creation with CreateComment * Removed unnecessary code * Improved error checking * Small cosmetic changes * Replaced int>string>duration parsing with int>duration parsing * Fixed encoding issues * Removed unused imports Signed-off-by: Jonas Franz <info@jonasfranz.software>
8 years ago
Pull request review/approval and comment on code (#3748) * Initial ui components for pull request review * Add Review Add IssueComment types Signed-off-by: Jonas Franz <info@jonasfranz.software> (cherry picked from commit 2b4daab) Signed-off-by: Jonas Franz <info@jonasfranz.software> * Replace ReviewComment with Content Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add load functions Add ReviewID to findComments Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add create review comment implementation Add migration for review Other small changes Signed-off-by: Jonas Franz <info@jonasfranz.software> * Simplified create and find functions for review Signed-off-by: Jonas Franz <info@jonasfranz.software> * Moved "Pending" to first position Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add GetCurrentReview to simplify fetching current review Signed-off-by: Jonas Franz <info@jonasfranz.software> * Preview for listing comments Signed-off-by: Jonas Franz <info@jonasfranz.software> * Move new comment form to its own file Signed-off-by: Jonas Franz <info@jonasfranz.software> * Implement Review form Show Review comments on comment stream Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add support for single comments Showing buttons in context Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add pending tag to pending review comments Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add unit tests for Review Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fetch all review ids at once Add unit tests Signed-off-by: Jonas Franz <info@jonasfranz.software> * gofmt Signed-off-by: Jonas Franz <info@jonasfranz.software> * Improved comment rendering in "Files" view by adding Comments to DiffLine Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add support for invalidating comments Signed-off-by: Jonas Franz <info@jonasfranz.software> * Switched back to code.gitea.io/git Signed-off-by: Jonas Franz <info@jonasfranz.software> * Moved review migration from v64 to v65 Signed-off-by: Jonas Franz <info@jonasfranz.software> * Rebuild css Signed-off-by: Jonas Franz <info@jonasfranz.software> * gofmt Signed-off-by: Jonas Franz <info@jonasfranz.software> * Improve translations Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix unit tests by updating fixtures and updating outdated test Signed-off-by: Jonas Franz <info@jonasfranz.software> * Comments will be shown at the right place now Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add support for deleting CodeComments Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix problems caused by files in subdirectories Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add support for showing code comments of reviews in conversation Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add support for "Show/Hide outdated" Signed-off-by: Jonas Franz <info@jonasfranz.software> * Update code.gitea.io/git Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add support for new webhooks Signed-off-by: Jonas Franz <info@jonasfranz.software> * Update comparison Signed-off-by: Jonas Franz <info@jonasfranz.software> * Resolve conflicts Signed-off-by: Jonas Franz <info@jonasfranz.software> * Minor UI improvements * update code.gitea.io/git * Fix ui bug reported by @lunny causing wrong position of add button Add functionality to "Cancel" button Add scale effects to add button Hide "Cancel" button for existing comments Signed-off-by: Jonas Franz <info@jonasfranz.software> * Prepare solving conflicts Signed-off-by: Jonas Franz <info@jonasfranz.software> * Show add button only if no comments already exist for the line Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add missing vendor files Signed-off-by: Jonas Franz <info@jonasfranz.software> * Check if reviewer is nil Signed-off-by: Jonas Franz <info@jonasfranz.software> * Show forms only to users who are logged in Signed-off-by: Jonas Franz <info@jonasfranz.software> * Revert "Show forms only to users who are logged in" This reverts commit c083682 Signed-off-by: Jonas Franz <info@jonasfranz.software> * Save patch in comment Render patch for code comments Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add link to comment in code Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add reply form to comment list Show forms only to signed in users Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add 'Reply' as translatable Add CODE_COMMENT_LINES setting Signed-off-by: Jonas Franz <info@jonasfranz.software> * gofmt Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix problems introduced by checking for singed in user Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add v70 Signed-off-by: Jonas Franz <info@jonasfranz.software> * Update generated stylesheet Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix preview Beginn with new review comment patch system Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add new algo to generate diff for line range Remove old algo used for cutting big diffs (it was very buggy) * Add documentation and example for CutDiffAroundLine * Fix example of CutDiffAroundLine * Fix some comment UI rendering bugs * Add code comment edit mode * Send notifications / actions to users until review gets published Fix diff generation bug Fix wrong hashtag * Fix vet errors * Send notifications also for single comments * Fix some notification bugs, fix link * Fix: add comment icon is only shown on code lines * Add lint comment * Add unit tests for git diff * Add more error messages * Regenerated css Signed-off-by: Jonas Franz <info@jonasfranz.software> * fmt Signed-off-by: Jonas Franz <info@jonasfranz.software> * Regenerated CSS with latest less version Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix test by updating comment type to new ID Signed-off-by: Jonas Franz <info@jonasfranz.software> * Introducing CodeComments as type for map[string]map[int64][]*Comment Other minor code improvements Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix data-tab issues Signed-off-by: Jonas Franz <info@jonasfranz.software> * Remove unnecessary change Signed-off-by: Jonas Franz <info@jonasfranz.software> * refactored checkForInvalidation Signed-off-by: Jonas Franz <info@jonasfranz.software> * Append comments instead of setting Signed-off-by: Jonas Franz <info@jonasfranz.software> * Use HeadRepo instead of BaseRepo Signed-off-by: Jonas Franz <info@jonasfranz.software> * Update migration Signed-off-by: Jonas Franz <info@jonasfranz.de> * Regenerated CSS Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add copyright Signed-off-by: Jonas Franz <info@jonasfranz.software> * Update index.css Signed-off-by: Jonas Franz <info@jonasfranz.software>
7 years ago
Pull request review/approval and comment on code (#3748) * Initial ui components for pull request review * Add Review Add IssueComment types Signed-off-by: Jonas Franz <info@jonasfranz.software> (cherry picked from commit 2b4daab) Signed-off-by: Jonas Franz <info@jonasfranz.software> * Replace ReviewComment with Content Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add load functions Add ReviewID to findComments Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add create review comment implementation Add migration for review Other small changes Signed-off-by: Jonas Franz <info@jonasfranz.software> * Simplified create and find functions for review Signed-off-by: Jonas Franz <info@jonasfranz.software> * Moved "Pending" to first position Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add GetCurrentReview to simplify fetching current review Signed-off-by: Jonas Franz <info@jonasfranz.software> * Preview for listing comments Signed-off-by: Jonas Franz <info@jonasfranz.software> * Move new comment form to its own file Signed-off-by: Jonas Franz <info@jonasfranz.software> * Implement Review form Show Review comments on comment stream Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add support for single comments Showing buttons in context Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add pending tag to pending review comments Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add unit tests for Review Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fetch all review ids at once Add unit tests Signed-off-by: Jonas Franz <info@jonasfranz.software> * gofmt Signed-off-by: Jonas Franz <info@jonasfranz.software> * Improved comment rendering in "Files" view by adding Comments to DiffLine Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add support for invalidating comments Signed-off-by: Jonas Franz <info@jonasfranz.software> * Switched back to code.gitea.io/git Signed-off-by: Jonas Franz <info@jonasfranz.software> * Moved review migration from v64 to v65 Signed-off-by: Jonas Franz <info@jonasfranz.software> * Rebuild css Signed-off-by: Jonas Franz <info@jonasfranz.software> * gofmt Signed-off-by: Jonas Franz <info@jonasfranz.software> * Improve translations Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix unit tests by updating fixtures and updating outdated test Signed-off-by: Jonas Franz <info@jonasfranz.software> * Comments will be shown at the right place now Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add support for deleting CodeComments Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix problems caused by files in subdirectories Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add support for showing code comments of reviews in conversation Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add support for "Show/Hide outdated" Signed-off-by: Jonas Franz <info@jonasfranz.software> * Update code.gitea.io/git Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add support for new webhooks Signed-off-by: Jonas Franz <info@jonasfranz.software> * Update comparison Signed-off-by: Jonas Franz <info@jonasfranz.software> * Resolve conflicts Signed-off-by: Jonas Franz <info@jonasfranz.software> * Minor UI improvements * update code.gitea.io/git * Fix ui bug reported by @lunny causing wrong position of add button Add functionality to "Cancel" button Add scale effects to add button Hide "Cancel" button for existing comments Signed-off-by: Jonas Franz <info@jonasfranz.software> * Prepare solving conflicts Signed-off-by: Jonas Franz <info@jonasfranz.software> * Show add button only if no comments already exist for the line Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add missing vendor files Signed-off-by: Jonas Franz <info@jonasfranz.software> * Check if reviewer is nil Signed-off-by: Jonas Franz <info@jonasfranz.software> * Show forms only to users who are logged in Signed-off-by: Jonas Franz <info@jonasfranz.software> * Revert "Show forms only to users who are logged in" This reverts commit c083682 Signed-off-by: Jonas Franz <info@jonasfranz.software> * Save patch in comment Render patch for code comments Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add link to comment in code Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add reply form to comment list Show forms only to signed in users Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add 'Reply' as translatable Add CODE_COMMENT_LINES setting Signed-off-by: Jonas Franz <info@jonasfranz.software> * gofmt Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix problems introduced by checking for singed in user Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add v70 Signed-off-by: Jonas Franz <info@jonasfranz.software> * Update generated stylesheet Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix preview Beginn with new review comment patch system Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add new algo to generate diff for line range Remove old algo used for cutting big diffs (it was very buggy) * Add documentation and example for CutDiffAroundLine * Fix example of CutDiffAroundLine * Fix some comment UI rendering bugs * Add code comment edit mode * Send notifications / actions to users until review gets published Fix diff generation bug Fix wrong hashtag * Fix vet errors * Send notifications also for single comments * Fix some notification bugs, fix link * Fix: add comment icon is only shown on code lines * Add lint comment * Add unit tests for git diff * Add more error messages * Regenerated css Signed-off-by: Jonas Franz <info@jonasfranz.software> * fmt Signed-off-by: Jonas Franz <info@jonasfranz.software> * Regenerated CSS with latest less version Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix test by updating comment type to new ID Signed-off-by: Jonas Franz <info@jonasfranz.software> * Introducing CodeComments as type for map[string]map[int64][]*Comment Other minor code improvements Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix data-tab issues Signed-off-by: Jonas Franz <info@jonasfranz.software> * Remove unnecessary change Signed-off-by: Jonas Franz <info@jonasfranz.software> * refactored checkForInvalidation Signed-off-by: Jonas Franz <info@jonasfranz.software> * Append comments instead of setting Signed-off-by: Jonas Franz <info@jonasfranz.software> * Use HeadRepo instead of BaseRepo Signed-off-by: Jonas Franz <info@jonasfranz.software> * Update migration Signed-off-by: Jonas Franz <info@jonasfranz.de> * Regenerated CSS Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add copyright Signed-off-by: Jonas Franz <info@jonasfranz.software> * Update index.css Signed-off-by: Jonas Franz <info@jonasfranz.software>
7 years ago
Repository avatars (#6986) * Repository avatars - first variant of code from old work for gogs - add migration 87 - add new option in app.ini - add en-US locale string - add new class in repository.less * Add changed index.css, remove unused template name * Update en-us doc about configuration options * Add comments to new functions, add new option to docker app.ini * Add comment for lint * Remove variable, not needed * Fix formatting * Update swagger api template * Check if avatar exists * Fix avatar link/path checks * Typo * TEXT column can't have a default value * Fixes: - remove old avatar file on upload - use ID in name of avatar file - users may upload same files - add simple tests * Fix fmt check * Generate PNG instead of "static" GIF * More informative comment * Fix error message * Update avatar upload checks: - add file size check - add new option - update config docs - add new string to en-us locale * Fixes: - use FileHEader field for check file size - add new test - upload big image * Fix formatting * Update comments * Update log message * Removed wrong style - not needed * Use Sync2 to migrate * Update repos list view - bigger avatar - fix html blocks alignment * A little adjust avatar size * Use small icons for explore/repo list * Use new cool avatar preparation func by @lafriks * Missing changes for new function * Remove unused import, move imports * Missed new option definition in app.ini Add file size check in user/profile avatar upload * Use smaller field length for Avatar * Use session to update repo DB data, update DeleteAvatar - use session too * Fix err variable definition * As suggested @lafriks - return as soon as possible, code readability
6 years ago
Template Repositories (#8768) * Start work on templates Signed-off-by: jolheiser <john.olheiser@gmail.com> * Continue work Signed-off-by: jolheiser <john.olheiser@gmail.com> * Fix IsTemplate vs IsGenerated Signed-off-by: jolheiser <john.olheiser@gmail.com> * Fix tabs vs spaces * Tabs vs Spaces * Add templates to API & start adding tests Signed-off-by: jolheiser <john.olheiser@gmail.com> * Fix integration tests Signed-off-by: jolheiser <john.olheiser@gmail.com> * Remove unused User Signed-off-by: jolheiser <john.olheiser@gmail.com> * Move template tests to existing repos Signed-off-by: jolheiser <john.olheiser@gmail.com> * Minor re-check updates and cleanup Signed-off-by: jolheiser <john.olheiser@gmail.com> * make fmt Signed-off-by: jolheiser <john.olheiser@gmail.com> * Test cleanup Signed-off-by: jolheiser <john.olheiser@gmail.com> * Fix optionalbool Signed-off-by: jolheiser <john.olheiser@gmail.com> * make fmt Signed-off-by: jolheiser <john.olheiser@gmail.com> * Test fixes and icon change Signed-off-by: jolheiser <john.olheiser@gmail.com> * Add new user and repo for tests Signed-off-by: jolheiser <john.olheiser@gmail.com> * Fix tests (finally) Signed-off-by: jolheiser <john.olheiser@gmail.com> * Update meta repo with env variables Signed-off-by: jolheiser <john.olheiser@gmail.com> * Move generation to create page Combine with repo create template Modify API search to prioritize owner for repo Signed-off-by: jolheiser <john.olheiser@gmail.com> * Fix tests and coverage Signed-off-by: jolheiser <john.olheiser@gmail.com> * Fix swagger and JS lint Signed-off-by: jolheiser <john.olheiser@gmail.com> * Fix API searching for own private repos Signed-off-by: jolheiser <john.olheiser@gmail.com> * Change wording Signed-off-by: jolheiser <john.olheiser@gmail.com> * Fix repo search test. User had a private repo that didn't show up Signed-off-by: jolheiser <john.olheiser@gmail.com> * Another search test fix Signed-off-by: jolheiser <john.olheiser@gmail.com> * Clarify git content Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com> * Feedback updates Signed-off-by: jolheiser <john.olheiser@gmail.com> * Add topics WIP Signed-off-by: jolheiser <john.olheiser@gmail.com> * Finish adding topics Signed-off-by: jolheiser <john.olheiser@gmail.com> * Update locale Signed-off-by: jolheiser <john.olheiser@gmail.com>
6 years ago
Better logging (#6038) (#6095) * Panic don't fatal on create new logger Fixes #5854 Signed-off-by: Andrew Thornton <art27@cantab.net> * partial broken * Update the logging infrastrcture Signed-off-by: Andrew Thornton <art27@cantab.net> * Reset the skip levels for Fatal and Error Signed-off-by: Andrew Thornton <art27@cantab.net> * broken ncsa * More log.Error fixes Signed-off-by: Andrew Thornton <art27@cantab.net> * Remove nal * set log-levels to lowercase * Make console_test test all levels * switch to lowercased levels * OK now working * Fix vetting issues * Fix lint * Fix tests * change default logging to match current gitea * Improve log testing Signed-off-by: Andrew Thornton <art27@cantab.net> * reset error skip levels to 0 * Update documentation and access logger configuration * Redirect the router log back to gitea if redirect macaron log but also allow setting the log level - i.e. TRACE * Fix broken level caching * Refactor the router log * Add Router logger * Add colorizing options * Adjust router colors * Only create logger if they will be used * update app.ini.sample * rename Attribute ColorAttribute * Change from white to green for function * Set fatal/error levels * Restore initial trace logger * Fix Trace arguments in modules/auth/auth.go * Properly handle XORMLogger * Improve admin/config page * fix fmt * Add auto-compression of old logs * Update error log levels * Remove the unnecessary skip argument from Error, Fatal and Critical * Add stacktrace support * Fix tests * Remove x/sync from vendors? * Add stderr option to console logger * Use filepath.ToSlash to protect against Windows in tests * Remove prefixed underscores from names in colors.go * Remove not implemented database logger This was removed from Gogs on 4 Mar 2016 but left in the configuration since then. * Ensure that log paths are relative to ROOT_PATH * use path.Join * rename jsonConfig to logConfig * Rename "config" to "jsonConfig" to make it clearer * Requested changes * Requested changes: XormLogger * Try to color the windows terminal If successful default to colorizing the console logs * fixup * Colorize initially too * update vendor * Colorize logs on default and remove if this is not a colorizing logger * Fix documentation * fix test * Use go-isatty to detect if on windows we are on msys or cygwin * Fix spelling mistake * Add missing vendors * More changes * Rationalise the ANSI writer protection * Adjust colors on advice from @0x5c * Make Flags a comma separated list * Move to use the windows constant for ENABLE_VIRTUAL_TERMINAL_PROCESSING * Ensure matching is done on the non-colored message - to simpify EXPRESSION
6 years ago
Better logging (#6038) (#6095) * Panic don't fatal on create new logger Fixes #5854 Signed-off-by: Andrew Thornton <art27@cantab.net> * partial broken * Update the logging infrastrcture Signed-off-by: Andrew Thornton <art27@cantab.net> * Reset the skip levels for Fatal and Error Signed-off-by: Andrew Thornton <art27@cantab.net> * broken ncsa * More log.Error fixes Signed-off-by: Andrew Thornton <art27@cantab.net> * Remove nal * set log-levels to lowercase * Make console_test test all levels * switch to lowercased levels * OK now working * Fix vetting issues * Fix lint * Fix tests * change default logging to match current gitea * Improve log testing Signed-off-by: Andrew Thornton <art27@cantab.net> * reset error skip levels to 0 * Update documentation and access logger configuration * Redirect the router log back to gitea if redirect macaron log but also allow setting the log level - i.e. TRACE * Fix broken level caching * Refactor the router log * Add Router logger * Add colorizing options * Adjust router colors * Only create logger if they will be used * update app.ini.sample * rename Attribute ColorAttribute * Change from white to green for function * Set fatal/error levels * Restore initial trace logger * Fix Trace arguments in modules/auth/auth.go * Properly handle XORMLogger * Improve admin/config page * fix fmt * Add auto-compression of old logs * Update error log levels * Remove the unnecessary skip argument from Error, Fatal and Critical * Add stacktrace support * Fix tests * Remove x/sync from vendors? * Add stderr option to console logger * Use filepath.ToSlash to protect against Windows in tests * Remove prefixed underscores from names in colors.go * Remove not implemented database logger This was removed from Gogs on 4 Mar 2016 but left in the configuration since then. * Ensure that log paths are relative to ROOT_PATH * use path.Join * rename jsonConfig to logConfig * Rename "config" to "jsonConfig" to make it clearer * Requested changes * Requested changes: XormLogger * Try to color the windows terminal If successful default to colorizing the console logs * fixup * Colorize initially too * update vendor * Colorize logs on default and remove if this is not a colorizing logger * Fix documentation * fix test * Use go-isatty to detect if on windows we are on msys or cygwin * Fix spelling mistake * Add missing vendors * More changes * Rationalise the ANSI writer protection * Adjust colors on advice from @0x5c * Make Flags a comma separated list * Move to use the windows constant for ENABLE_VIRTUAL_TERMINAL_PROCESSING * Ensure matching is done on the non-colored message - to simpify EXPRESSION
6 years ago
10 years ago
10 years ago
10 years ago
123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888889890891892893894895896897898899900901902903904905906907908909910911912913914915916917918919920921922923924925926927928929930931932933934935936937938939940941942943944945946947948949950951952953954955956957958959960961962963964965966967968969970971972973974975976977978979980981982983984985986987988989990991992993994995996997998999100010011002100310041005100610071008100910101011101210131014101510161017101810191020102110221023102410251026102710281029103010311032103310341035103610371038103910401041104210431044104510461047104810491050105110521053105410551056105710581059106010611062106310641065106610671068
  1. // Copyright 2015 The Gogs Authors. All rights reserved.
  2. // Copyright 2017 The Gitea Authors. All rights reserved.
  3. // Use of this source code is governed by a MIT-style
  4. // license that can be found in the LICENSE file.
  5. package migrations
  6. import (
  7. "bytes"
  8. "encoding/json"
  9. "fmt"
  10. "io/ioutil"
  11. "os"
  12. "path"
  13. "path/filepath"
  14. "regexp"
  15. "strings"
  16. "time"
  17. "code.gitea.io/gitea/modules/generate"
  18. "code.gitea.io/gitea/modules/log"
  19. "code.gitea.io/gitea/modules/setting"
  20. gouuid "github.com/satori/go.uuid"
  21. "github.com/unknwon/com"
  22. ini "gopkg.in/ini.v1"
  23. "xorm.io/xorm"
  24. )
  25. const minDBVersion = 4
  26. // Migration describes on migration from lower version to high version
  27. type Migration interface {
  28. Description() string
  29. Migrate(*xorm.Engine) error
  30. }
  31. type migration struct {
  32. description string
  33. migrate func(*xorm.Engine) error
  34. }
  35. // NewMigration creates a new migration
  36. func NewMigration(desc string, fn func(*xorm.Engine) error) Migration {
  37. return &migration{desc, fn}
  38. }
  39. // Description returns the migration's description
  40. func (m *migration) Description() string {
  41. return m.description
  42. }
  43. // Migrate executes the migration
  44. func (m *migration) Migrate(x *xorm.Engine) error {
  45. return m.migrate(x)
  46. }
  47. // Version describes the version table. Should have only one row with id==1
  48. type Version struct {
  49. ID int64 `xorm:"pk autoincr"`
  50. Version int64
  51. }
  52. func emptyMigration(x *xorm.Engine) error {
  53. return nil
  54. }
  55. // This is a sequence of migrations. Add new migrations to the bottom of the list.
  56. // If you want to "retire" a migration, remove it from the top of the list and
  57. // update minDBVersion accordingly
  58. var migrations = []Migration{
  59. // v0 -> v4: before 0.6.0 -> 0.7.33
  60. NewMigration("fix locale file load panic", fixLocaleFileLoadPanic), // V4 -> V5:v0.6.0
  61. NewMigration("trim action compare URL prefix", trimCommitActionAppURLPrefix), // V5 -> V6:v0.6.3
  62. NewMigration("generate issue-label from issue", issueToIssueLabel), // V6 -> V7:v0.6.4
  63. NewMigration("refactor attachment table", attachmentRefactor), // V7 -> V8:v0.6.4
  64. NewMigration("rename pull request fields", renamePullRequestFields), // V8 -> V9:v0.6.16
  65. NewMigration("clean up migrate repo info", cleanUpMigrateRepoInfo), // V9 -> V10:v0.6.20
  66. NewMigration("generate rands and salt for organizations", generateOrgRandsAndSalt), // V10 -> V11:v0.8.5
  67. NewMigration("convert date to unix timestamp", convertDateToUnix), // V11 -> V12:v0.9.2
  68. NewMigration("convert LDAP UseSSL option to SecurityProtocol", ldapUseSSLToSecurityProtocol), // V12 -> V13:v0.9.37
  69. // v13 -> v14:v0.9.87
  70. NewMigration("set comment updated with created", setCommentUpdatedWithCreated),
  71. // v14 -> v15
  72. NewMigration("create user column diff view style", createUserColumnDiffViewStyle),
  73. // v15 -> v16
  74. NewMigration("create user column allow create organization", createAllowCreateOrganizationColumn),
  75. // V16 -> v17
  76. NewMigration("create repo unit table and add units for all repos", addUnitsToTables),
  77. // v17 -> v18
  78. NewMigration("set protect branches updated with created", setProtectedBranchUpdatedWithCreated),
  79. // v18 -> v19
  80. NewMigration("add external login user", addExternalLoginUser),
  81. // v19 -> v20
  82. NewMigration("generate and migrate Git hooks", generateAndMigrateGitHooks),
  83. // v20 -> v21
  84. NewMigration("use new avatar path name for security reason", useNewNameAvatars),
  85. // v21 -> v22
  86. NewMigration("rewrite authorized_keys file via new format", useNewPublickeyFormat),
  87. // v22 -> v23
  88. NewMigration("generate and migrate wiki Git hooks", generateAndMigrateWikiGitHooks),
  89. // v23 -> v24
  90. NewMigration("add user openid table", addUserOpenID),
  91. // v24 -> v25
  92. NewMigration("change the key_id and primary_key_id type", changeGPGKeysColumns),
  93. // v25 -> v26
  94. NewMigration("add show field in user openid table", addUserOpenIDShow),
  95. // v26 -> v27
  96. NewMigration("generate and migrate repo and wiki Git hooks", generateAndMigrateGitHookChains),
  97. // v27 -> v28
  98. NewMigration("change mirror interval from hours to time.Duration", convertIntervalToDuration),
  99. // v28 -> v29
  100. NewMigration("add field for repo size", addRepoSize),
  101. // v29 -> v30
  102. NewMigration("add commit status table", addCommitStatus),
  103. // v30 -> 31
  104. NewMigration("add primary key to external login user", addExternalLoginUserPK),
  105. // v31 -> 32
  106. NewMigration("add field for login source synchronization", addLoginSourceSyncEnabledColumn),
  107. // v32 -> v33
  108. NewMigration("add units for team", addUnitsToRepoTeam),
  109. // v33 -> v34
  110. NewMigration("remove columns from action", removeActionColumns),
  111. // v34 -> v35
  112. NewMigration("give all units to owner teams", giveAllUnitsToOwnerTeams),
  113. // v35 -> v36
  114. NewMigration("adds comment to an action", addCommentIDToAction),
  115. // v36 -> v37
  116. NewMigration("regenerate git hooks", regenerateGitHooks36),
  117. // v37 -> v38
  118. NewMigration("unescape user full names", unescapeUserFullNames),
  119. // v38 -> v39
  120. NewMigration("remove commits and settings unit types", removeCommitsUnitType),
  121. // v39 -> v40
  122. NewMigration("add tags to releases and sync existing repositories", releaseAddColumnIsTagAndSyncTags),
  123. // v40 -> v41
  124. NewMigration("fix protected branch can push value to false", fixProtectedBranchCanPushValue),
  125. // v41 -> v42
  126. NewMigration("remove duplicate unit types", removeDuplicateUnitTypes),
  127. // v42 -> v43
  128. NewMigration("empty step", emptyMigration),
  129. // v43 -> v44
  130. NewMigration("empty step", emptyMigration),
  131. // v44 -> v45
  132. NewMigration("empty step", emptyMigration),
  133. // v45 -> v46
  134. NewMigration("remove index column from repo_unit table", removeIndexColumnFromRepoUnitTable),
  135. // v46 -> v47
  136. NewMigration("remove organization watch repositories", removeOrganizationWatchRepo),
  137. // v47 -> v48
  138. NewMigration("add deleted branches", addDeletedBranch),
  139. // v48 -> v49
  140. NewMigration("add repo indexer status", addRepoIndexerStatus),
  141. // v49 -> v50
  142. NewMigration("adds time tracking and stopwatches", addTimetracking),
  143. // v50 -> v51
  144. NewMigration("migrate protected branch struct", migrateProtectedBranchStruct),
  145. // v51 -> v52
  146. NewMigration("add default value to user prohibit_login", addDefaultValueToUserProhibitLogin),
  147. // v52 -> v53
  148. NewMigration("add lfs lock table", addLFSLock),
  149. // v53 -> v54
  150. NewMigration("add reactions", addReactions),
  151. // v54 -> v55
  152. NewMigration("add pull request options", addPullRequestOptions),
  153. // v55 -> v56
  154. NewMigration("add writable deploy keys", addModeToDeploKeys),
  155. // v56 -> v57
  156. NewMigration("remove is_owner, num_teams columns from org_user", removeIsOwnerColumnFromOrgUser),
  157. // v57 -> v58
  158. NewMigration("add closed_unix column for issues", addIssueClosedTime),
  159. // v58 -> v59
  160. NewMigration("add label descriptions", addLabelsDescriptions),
  161. // v59 -> v60
  162. NewMigration("add merge whitelist for protected branches", addProtectedBranchMergeWhitelist),
  163. // v60 -> v61
  164. NewMigration("add is_fsck_enabled column for repos", addFsckEnabledToRepo),
  165. // v61 -> v62
  166. NewMigration("add size column for attachments", addSizeToAttachment),
  167. // v62 -> v63
  168. NewMigration("add last used passcode column for TOTP", addLastUsedPasscodeTOTP),
  169. // v63 -> v64
  170. NewMigration("add language column for user setting", addLanguageSetting),
  171. // v64 -> v65
  172. NewMigration("add multiple assignees", addMultipleAssignees),
  173. // v65 -> v66
  174. NewMigration("add u2f", addU2FReg),
  175. // v66 -> v67
  176. NewMigration("add login source id column for public_key table", addLoginSourceIDToPublicKeyTable),
  177. // v67 -> v68
  178. NewMigration("remove stale watches", removeStaleWatches),
  179. // v68 -> V69
  180. NewMigration("Reformat and remove incorrect topics", reformatAndRemoveIncorrectTopics),
  181. // v69 -> v70
  182. NewMigration("move team units to team_unit table", moveTeamUnitsToTeamUnitTable),
  183. // v70 -> v71
  184. NewMigration("add issue_dependencies", addIssueDependencies),
  185. // v71 -> v72
  186. NewMigration("protect each scratch token", addScratchHash),
  187. // v72 -> v73
  188. NewMigration("add review", addReview),
  189. // v73 -> v74
  190. NewMigration("add must_change_password column for users table", addMustChangePassword),
  191. // v74 -> v75
  192. NewMigration("add approval whitelists to protected branches", addApprovalWhitelistsToProtectedBranches),
  193. // v75 -> v76
  194. NewMigration("clear nonused data which not deleted when user was deleted", clearNonusedData),
  195. // v76 -> v77
  196. NewMigration("add pull request rebase with merge commit", addPullRequestRebaseWithMerge),
  197. // v77 -> v78
  198. NewMigration("add theme to users", addUserDefaultTheme),
  199. // v78 -> v79
  200. NewMigration("rename repo is_bare to repo is_empty", renameRepoIsBareToIsEmpty),
  201. // v79 -> v80
  202. NewMigration("add can close issues via commit in any branch", addCanCloseIssuesViaCommitInAnyBranch),
  203. // v80 -> v81
  204. NewMigration("add is locked to issues", addIsLockedToIssues),
  205. // v81 -> v82
  206. NewMigration("update U2F counter type", changeU2FCounterType),
  207. // v82 -> v83
  208. NewMigration("hot fix for wrong release sha1 on release table", fixReleaseSha1OnReleaseTable),
  209. // v83 -> v84
  210. NewMigration("add uploader id for table attachment", addUploaderIDForAttachment),
  211. // v84 -> v85
  212. NewMigration("add table to store original imported gpg keys", addGPGKeyImport),
  213. // v85 -> v86
  214. NewMigration("hash application token", hashAppToken),
  215. // v86 -> v87
  216. NewMigration("add http method to webhook", addHTTPMethodToWebhook),
  217. // v87 -> v88
  218. NewMigration("add avatar field to repository", addAvatarFieldToRepository),
  219. // v88 -> v89
  220. NewMigration("add commit status context field to commit_status", addCommitStatusContext),
  221. // v89 -> v90
  222. NewMigration("add original author/url migration info to issues, comments, and repo ", addOriginalMigrationInfo),
  223. // v90 -> v91
  224. NewMigration("change length of some repository columns", changeSomeColumnsLengthOfRepo),
  225. // v91 -> v92
  226. NewMigration("add index on owner_id of repository and type, review_id of comment", addIndexOnRepositoryAndComment),
  227. // v92 -> v93
  228. NewMigration("remove orphaned repository index statuses", removeLingeringIndexStatus),
  229. // v93 -> v94
  230. NewMigration("add email notification enabled preference to user", addEmailNotificationEnabledToUser),
  231. // v94 -> v95
  232. NewMigration("add enable_status_check, status_check_contexts to protected_branch", addStatusCheckColumnsForProtectedBranches),
  233. // v95 -> v96
  234. NewMigration("add table columns for cross referencing issues", addCrossReferenceColumns),
  235. // v96 -> v97
  236. NewMigration("delete orphaned attachments", deleteOrphanedAttachments),
  237. // v97 -> v98
  238. NewMigration("add repo_admin_change_team_access to user", addRepoAdminChangeTeamAccessColumnForUser),
  239. // v98 -> v99
  240. NewMigration("add original author name and id on migrated release", addOriginalAuthorOnMigratedReleases),
  241. // v99 -> v100
  242. NewMigration("add task table and status column for repository table", addTaskTable),
  243. // v100 -> v101
  244. NewMigration("update migration repositories' service type", updateMigrationServiceTypes),
  245. // v101 -> v102
  246. NewMigration("change length of some external login users columns", changeSomeColumnsLengthOfExternalLoginUser),
  247. // v102 -> v103
  248. NewMigration("update migration repositories' service type", dropColumnHeadUserNameOnPullRequest),
  249. // v103 -> v104
  250. NewMigration("Add WhitelistDeployKeys to protected branch", addWhitelistDeployKeysToBranches),
  251. // v104 -> v105
  252. NewMigration("remove unnecessary columns from label", removeLabelUneededCols),
  253. // v105 -> v106
  254. NewMigration("add includes_all_repositories to teams", addTeamIncludesAllRepositories),
  255. // v106 -> v107
  256. NewMigration("add column `mode` to table watch", addModeColumnToWatch),
  257. // v107 -> v108
  258. NewMigration("Add template options to repository", addTemplateToRepo),
  259. // v108 -> v109
  260. NewMigration("Add comment_id on table notification", addCommentIDOnNotification),
  261. // v109 -> v110
  262. NewMigration("add can_create_org_repo to team", addCanCreateOrgRepoColumnForTeam),
  263. }
  264. // Migrate database to current version
  265. func Migrate(x *xorm.Engine) error {
  266. if err := x.Sync(new(Version)); err != nil {
  267. return fmt.Errorf("sync: %v", err)
  268. }
  269. currentVersion := &Version{ID: 1}
  270. has, err := x.Get(currentVersion)
  271. if err != nil {
  272. return fmt.Errorf("get: %v", err)
  273. } else if !has {
  274. // If the version record does not exist we think
  275. // it is a fresh installation and we can skip all migrations.
  276. currentVersion.ID = 0
  277. currentVersion.Version = int64(minDBVersion + len(migrations))
  278. if _, err = x.InsertOne(currentVersion); err != nil {
  279. return fmt.Errorf("insert: %v", err)
  280. }
  281. }
  282. v := currentVersion.Version
  283. if minDBVersion > v {
  284. log.Fatal(`Gitea no longer supports auto-migration from your previously installed version.
  285. Please try to upgrade to a lower version (>= v0.6.0) first, then upgrade to current version.`)
  286. return nil
  287. }
  288. if int(v-minDBVersion) > len(migrations) {
  289. // User downgraded Gitea.
  290. currentVersion.Version = int64(len(migrations) + minDBVersion)
  291. _, err = x.ID(1).Update(currentVersion)
  292. return err
  293. }
  294. for i, m := range migrations[v-minDBVersion:] {
  295. log.Info("Migration[%d]: %s", v+int64(i), m.Description())
  296. if err = m.Migrate(x); err != nil {
  297. return fmt.Errorf("do migrate: %v", err)
  298. }
  299. currentVersion.Version = v + int64(i) + 1
  300. if _, err = x.ID(1).Update(currentVersion); err != nil {
  301. return err
  302. }
  303. }
  304. return nil
  305. }
  306. func dropTableColumns(sess *xorm.Session, tableName string, columnNames ...string) (err error) {
  307. if tableName == "" || len(columnNames) == 0 {
  308. return nil
  309. }
  310. // TODO: This will not work if there are foreign keys
  311. switch {
  312. case setting.Database.UseSQLite3:
  313. // First drop the indexes on the columns
  314. res, errIndex := sess.Query(fmt.Sprintf("PRAGMA index_list(`%s`)", tableName))
  315. if errIndex != nil {
  316. return errIndex
  317. }
  318. for _, row := range res {
  319. indexName := row["name"]
  320. indexRes, err := sess.Query(fmt.Sprintf("PRAGMA index_info(`%s`)", indexName))
  321. if err != nil {
  322. return err
  323. }
  324. if len(indexRes) != 1 {
  325. continue
  326. }
  327. indexColumn := string(indexRes[0]["name"])
  328. for _, name := range columnNames {
  329. if name == indexColumn {
  330. _, err := sess.Exec(fmt.Sprintf("DROP INDEX `%s`", indexName))
  331. if err != nil {
  332. return err
  333. }
  334. }
  335. }
  336. }
  337. // Here we need to get the columns from the original table
  338. sql := fmt.Sprintf("SELECT sql FROM sqlite_master WHERE tbl_name='%s' and type='table'", tableName)
  339. res, err := sess.Query(sql)
  340. if err != nil {
  341. return err
  342. }
  343. tableSQL := string(res[0]["sql"])
  344. // Separate out the column definitions
  345. tableSQL = tableSQL[strings.Index(tableSQL, "("):]
  346. // Remove the required columnNames
  347. for _, name := range columnNames {
  348. tableSQL = regexp.MustCompile(regexp.QuoteMeta("`"+name+"`")+"[^`,)]*?[,)]").ReplaceAllString(tableSQL, "")
  349. }
  350. // Ensure the query is ended properly
  351. tableSQL = strings.TrimSpace(tableSQL)
  352. if tableSQL[len(tableSQL)-1] != ')' {
  353. if tableSQL[len(tableSQL)-1] == ',' {
  354. tableSQL = tableSQL[:len(tableSQL)-1]
  355. }
  356. tableSQL += ")"
  357. }
  358. // Find all the columns in the table
  359. columns := regexp.MustCompile("`([^`]*)`").FindAllString(tableSQL, -1)
  360. tableSQL = fmt.Sprintf("CREATE TABLE `new_%s_new` ", tableName) + tableSQL
  361. if _, err := sess.Exec(tableSQL); err != nil {
  362. return err
  363. }
  364. // Now restore the data
  365. columnsSeparated := strings.Join(columns, ",")
  366. insertSQL := fmt.Sprintf("INSERT INTO `new_%s_new` (%s) SELECT %s FROM %s", tableName, columnsSeparated, columnsSeparated, tableName)
  367. if _, err := sess.Exec(insertSQL); err != nil {
  368. return err
  369. }
  370. // Now drop the old table
  371. if _, err := sess.Exec(fmt.Sprintf("DROP TABLE `%s`", tableName)); err != nil {
  372. return err
  373. }
  374. // Rename the table
  375. if _, err := sess.Exec(fmt.Sprintf("ALTER TABLE `new_%s_new` RENAME TO `%s`", tableName, tableName)); err != nil {
  376. return err
  377. }
  378. case setting.Database.UsePostgreSQL:
  379. cols := ""
  380. for _, col := range columnNames {
  381. if cols != "" {
  382. cols += ", "
  383. }
  384. cols += "DROP COLUMN `" + col + "` CASCADE"
  385. }
  386. if _, err := sess.Exec(fmt.Sprintf("ALTER TABLE `%s` %s", tableName, cols)); err != nil {
  387. return fmt.Errorf("Drop table `%s` columns %v: %v", tableName, columnNames, err)
  388. }
  389. case setting.Database.UseMySQL:
  390. // Drop indexes on columns first
  391. sql := fmt.Sprintf("SHOW INDEX FROM %s WHERE column_name IN ('%s')", tableName, strings.Join(columnNames, "','"))
  392. res, err := sess.Query(sql)
  393. if err != nil {
  394. return err
  395. }
  396. for _, index := range res {
  397. indexName := index["column_name"]
  398. if len(indexName) > 0 {
  399. _, err := sess.Exec(fmt.Sprintf("DROP INDEX `%s` ON `%s`", indexName, tableName))
  400. if err != nil {
  401. return err
  402. }
  403. }
  404. }
  405. // Now drop the columns
  406. cols := ""
  407. for _, col := range columnNames {
  408. if cols != "" {
  409. cols += ", "
  410. }
  411. cols += "DROP COLUMN `" + col + "`"
  412. }
  413. if _, err := sess.Exec(fmt.Sprintf("ALTER TABLE `%s` %s", tableName, cols)); err != nil {
  414. return fmt.Errorf("Drop table `%s` columns %v: %v", tableName, columnNames, err)
  415. }
  416. case setting.Database.UseMSSQL:
  417. cols := ""
  418. for _, col := range columnNames {
  419. if cols != "" {
  420. cols += ", "
  421. }
  422. cols += "`" + strings.ToLower(col) + "`"
  423. }
  424. sql := fmt.Sprintf("SELECT Name FROM SYS.DEFAULT_CONSTRAINTS WHERE PARENT_OBJECT_ID = OBJECT_ID('%[1]s') AND PARENT_COLUMN_ID IN (SELECT column_id FROM sys.columns WHERE lower(NAME) IN (%[2]s) AND object_id = OBJECT_ID('%[1]s'))",
  425. tableName, strings.Replace(cols, "`", "'", -1))
  426. constraints := make([]string, 0)
  427. if err := sess.SQL(sql).Find(&constraints); err != nil {
  428. sess.Rollback()
  429. return fmt.Errorf("Find constraints: %v", err)
  430. }
  431. for _, constraint := range constraints {
  432. if _, err := sess.Exec(fmt.Sprintf("ALTER TABLE `%s` DROP CONSTRAINT `%s`", tableName, constraint)); err != nil {
  433. sess.Rollback()
  434. return fmt.Errorf("Drop table `%s` constraint `%s`: %v", tableName, constraint, err)
  435. }
  436. }
  437. if _, err := sess.Exec(fmt.Sprintf("ALTER TABLE `%s` DROP COLUMN %s", tableName, cols)); err != nil {
  438. sess.Rollback()
  439. return fmt.Errorf("Drop table `%s` columns %v: %v", tableName, columnNames, err)
  440. }
  441. return sess.Commit()
  442. default:
  443. log.Fatal("Unrecognized DB")
  444. }
  445. return nil
  446. }
  447. func fixLocaleFileLoadPanic(_ *xorm.Engine) error {
  448. cfg, err := ini.Load(setting.CustomConf)
  449. if err != nil {
  450. return fmt.Errorf("load custom config: %v", err)
  451. }
  452. cfg.DeleteSection("i18n")
  453. if err = cfg.SaveTo(setting.CustomConf); err != nil {
  454. return fmt.Errorf("save custom config: %v", err)
  455. }
  456. setting.Langs = strings.Split(strings.Replace(strings.Join(setting.Langs, ","), "fr-CA", "fr-FR", 1), ",")
  457. return nil
  458. }
  459. func trimCommitActionAppURLPrefix(x *xorm.Engine) error {
  460. type PushCommit struct {
  461. Sha1 string
  462. Message string
  463. AuthorEmail string
  464. AuthorName string
  465. }
  466. type PushCommits struct {
  467. Len int
  468. Commits []*PushCommit
  469. CompareURL string `json:"CompareUrl"`
  470. }
  471. type Action struct {
  472. ID int64 `xorm:"pk autoincr"`
  473. Content string `xorm:"TEXT"`
  474. }
  475. results, err := x.Query("SELECT `id`,`content` FROM `action` WHERE `op_type`=?", 5)
  476. if err != nil {
  477. return fmt.Errorf("select commit actions: %v", err)
  478. }
  479. sess := x.NewSession()
  480. defer sess.Close()
  481. if err = sess.Begin(); err != nil {
  482. return err
  483. }
  484. var pushCommits *PushCommits
  485. for _, action := range results {
  486. actID := com.StrTo(string(action["id"])).MustInt64()
  487. if actID == 0 {
  488. continue
  489. }
  490. pushCommits = new(PushCommits)
  491. if err = json.Unmarshal(action["content"], pushCommits); err != nil {
  492. return fmt.Errorf("unmarshal action content[%d]: %v", actID, err)
  493. }
  494. infos := strings.Split(pushCommits.CompareURL, "/")
  495. if len(infos) <= 4 {
  496. continue
  497. }
  498. pushCommits.CompareURL = strings.Join(infos[len(infos)-4:], "/")
  499. p, err := json.Marshal(pushCommits)
  500. if err != nil {
  501. return fmt.Errorf("marshal action content[%d]: %v", actID, err)
  502. }
  503. if _, err = sess.ID(actID).Update(&Action{
  504. Content: string(p),
  505. }); err != nil {
  506. return fmt.Errorf("update action[%d]: %v", actID, err)
  507. }
  508. }
  509. return sess.Commit()
  510. }
  511. func issueToIssueLabel(x *xorm.Engine) error {
  512. type IssueLabel struct {
  513. ID int64 `xorm:"pk autoincr"`
  514. IssueID int64 `xorm:"UNIQUE(s)"`
  515. LabelID int64 `xorm:"UNIQUE(s)"`
  516. }
  517. issueLabels := make([]*IssueLabel, 0, 50)
  518. results, err := x.Query("SELECT `id`,`label_ids` FROM `issue`")
  519. if err != nil {
  520. if strings.Contains(err.Error(), "no such column") ||
  521. strings.Contains(err.Error(), "Unknown column") {
  522. return nil
  523. }
  524. return fmt.Errorf("select issues: %v", err)
  525. }
  526. for _, issue := range results {
  527. issueID := com.StrTo(issue["id"]).MustInt64()
  528. // Just in case legacy code can have duplicated IDs for same label.
  529. mark := make(map[int64]bool)
  530. for _, idStr := range strings.Split(string(issue["label_ids"]), "|") {
  531. labelID := com.StrTo(strings.TrimPrefix(idStr, "$")).MustInt64()
  532. if labelID == 0 || mark[labelID] {
  533. continue
  534. }
  535. mark[labelID] = true
  536. issueLabels = append(issueLabels, &IssueLabel{
  537. IssueID: issueID,
  538. LabelID: labelID,
  539. })
  540. }
  541. }
  542. sess := x.NewSession()
  543. defer sess.Close()
  544. if err = sess.Begin(); err != nil {
  545. return err
  546. }
  547. if err = sess.Sync2(new(IssueLabel)); err != nil {
  548. return fmt.Errorf("Sync2: %v", err)
  549. } else if _, err = sess.Insert(issueLabels); err != nil {
  550. return fmt.Errorf("insert issue-labels: %v", err)
  551. }
  552. return sess.Commit()
  553. }
  554. func attachmentRefactor(x *xorm.Engine) error {
  555. type Attachment struct {
  556. ID int64 `xorm:"pk autoincr"`
  557. UUID string `xorm:"uuid INDEX"`
  558. // For rename purpose.
  559. Path string `xorm:"-"`
  560. NewPath string `xorm:"-"`
  561. }
  562. results, err := x.Query("SELECT * FROM `attachment`")
  563. if err != nil {
  564. return fmt.Errorf("select attachments: %v", err)
  565. }
  566. attachments := make([]*Attachment, 0, len(results))
  567. for _, attach := range results {
  568. if !com.IsExist(string(attach["path"])) {
  569. // If the attachment is already missing, there is no point to update it.
  570. continue
  571. }
  572. attachments = append(attachments, &Attachment{
  573. ID: com.StrTo(attach["id"]).MustInt64(),
  574. UUID: gouuid.NewV4().String(),
  575. Path: string(attach["path"]),
  576. })
  577. }
  578. sess := x.NewSession()
  579. defer sess.Close()
  580. if err = sess.Begin(); err != nil {
  581. return err
  582. }
  583. if err = sess.Sync2(new(Attachment)); err != nil {
  584. return fmt.Errorf("Sync2: %v", err)
  585. }
  586. // Note: Roll back for rename can be a dead loop,
  587. // so produces a backup file.
  588. var buf bytes.Buffer
  589. buf.WriteString("# old path -> new path\n")
  590. // Update database first because this is where error happens the most often.
  591. for _, attach := range attachments {
  592. if _, err = sess.ID(attach.ID).Update(attach); err != nil {
  593. return err
  594. }
  595. attach.NewPath = path.Join(setting.AttachmentPath, attach.UUID[0:1], attach.UUID[1:2], attach.UUID)
  596. buf.WriteString(attach.Path)
  597. buf.WriteString("\t")
  598. buf.WriteString(attach.NewPath)
  599. buf.WriteString("\n")
  600. }
  601. // Then rename attachments.
  602. isSucceed := true
  603. defer func() {
  604. if isSucceed {
  605. return
  606. }
  607. dumpPath := path.Join(setting.LogRootPath, "attachment_path.dump")
  608. ioutil.WriteFile(dumpPath, buf.Bytes(), 0666)
  609. log.Info("Failed to rename some attachments, old and new paths are saved into: %s", dumpPath)
  610. }()
  611. for _, attach := range attachments {
  612. if err = os.MkdirAll(path.Dir(attach.NewPath), os.ModePerm); err != nil {
  613. isSucceed = false
  614. return err
  615. }
  616. if err = os.Rename(attach.Path, attach.NewPath); err != nil {
  617. isSucceed = false
  618. return err
  619. }
  620. }
  621. return sess.Commit()
  622. }
  623. func renamePullRequestFields(x *xorm.Engine) (err error) {
  624. type PullRequest struct {
  625. ID int64 `xorm:"pk autoincr"`
  626. PullID int64 `xorm:"INDEX"`
  627. PullIndex int64
  628. HeadBarcnh string
  629. IssueID int64 `xorm:"INDEX"`
  630. Index int64
  631. HeadBranch string
  632. }
  633. if err = x.Sync(new(PullRequest)); err != nil {
  634. return fmt.Errorf("sync: %v", err)
  635. }
  636. results, err := x.Query("SELECT `id`,`pull_id`,`pull_index`,`head_barcnh` FROM `pull_request`")
  637. if err != nil {
  638. if strings.Contains(err.Error(), "no such column") {
  639. return nil
  640. }
  641. return fmt.Errorf("select pull requests: %v", err)
  642. }
  643. sess := x.NewSession()
  644. defer sess.Close()
  645. if err = sess.Begin(); err != nil {
  646. return err
  647. }
  648. var pull *PullRequest
  649. for _, pr := range results {
  650. pull = &PullRequest{
  651. ID: com.StrTo(pr["id"]).MustInt64(),
  652. IssueID: com.StrTo(pr["pull_id"]).MustInt64(),
  653. Index: com.StrTo(pr["pull_index"]).MustInt64(),
  654. HeadBranch: string(pr["head_barcnh"]),
  655. }
  656. if pull.Index == 0 {
  657. continue
  658. }
  659. if _, err = sess.ID(pull.ID).Update(pull); err != nil {
  660. return err
  661. }
  662. }
  663. return sess.Commit()
  664. }
  665. func cleanUpMigrateRepoInfo(x *xorm.Engine) (err error) {
  666. type (
  667. User struct {
  668. ID int64 `xorm:"pk autoincr"`
  669. LowerName string
  670. }
  671. Repository struct {
  672. ID int64 `xorm:"pk autoincr"`
  673. OwnerID int64
  674. LowerName string
  675. }
  676. )
  677. repos := make([]*Repository, 0, 25)
  678. if err = x.Where("is_mirror=?", false).Find(&repos); err != nil {
  679. return fmt.Errorf("select all non-mirror repositories: %v", err)
  680. }
  681. var user *User
  682. for _, repo := range repos {
  683. user = &User{ID: repo.OwnerID}
  684. has, err := x.Get(user)
  685. if err != nil {
  686. return fmt.Errorf("get owner of repository[%d - %d]: %v", repo.ID, repo.OwnerID, err)
  687. } else if !has {
  688. continue
  689. }
  690. configPath := filepath.Join(setting.RepoRootPath, user.LowerName, repo.LowerName+".git/config")
  691. // In case repository file is somehow missing.
  692. if !com.IsFile(configPath) {
  693. continue
  694. }
  695. cfg, err := ini.Load(configPath)
  696. if err != nil {
  697. return fmt.Errorf("open config file: %v", err)
  698. }
  699. cfg.DeleteSection("remote \"origin\"")
  700. if err = cfg.SaveToIndent(configPath, "\t"); err != nil {
  701. return fmt.Errorf("save config file: %v", err)
  702. }
  703. }
  704. return nil
  705. }
  706. func generateOrgRandsAndSalt(x *xorm.Engine) (err error) {
  707. type User struct {
  708. ID int64 `xorm:"pk autoincr"`
  709. Rands string `xorm:"VARCHAR(10)"`
  710. Salt string `xorm:"VARCHAR(10)"`
  711. }
  712. orgs := make([]*User, 0, 10)
  713. if err = x.Where("type=1").And("rands=''").Find(&orgs); err != nil {
  714. return fmt.Errorf("select all organizations: %v", err)
  715. }
  716. sess := x.NewSession()
  717. defer sess.Close()
  718. if err = sess.Begin(); err != nil {
  719. return err
  720. }
  721. for _, org := range orgs {
  722. if org.Rands, err = generate.GetRandomString(10); err != nil {
  723. return err
  724. }
  725. if org.Salt, err = generate.GetRandomString(10); err != nil {
  726. return err
  727. }
  728. if _, err = sess.ID(org.ID).Update(org); err != nil {
  729. return err
  730. }
  731. }
  732. return sess.Commit()
  733. }
  734. // TAction defines the struct for migrating table action
  735. type TAction struct {
  736. ID int64 `xorm:"pk autoincr"`
  737. CreatedUnix int64
  738. }
  739. // TableName will be invoked by XORM to customrize the table name
  740. func (t *TAction) TableName() string { return "action" }
  741. // TNotice defines the struct for migrating table notice
  742. type TNotice struct {
  743. ID int64 `xorm:"pk autoincr"`
  744. CreatedUnix int64
  745. }
  746. // TableName will be invoked by XORM to customrize the table name
  747. func (t *TNotice) TableName() string { return "notice" }
  748. // TComment defines the struct for migrating table comment
  749. type TComment struct {
  750. ID int64 `xorm:"pk autoincr"`
  751. CreatedUnix int64
  752. }
  753. // TableName will be invoked by XORM to customrize the table name
  754. func (t *TComment) TableName() string { return "comment" }
  755. // TIssue defines the struct for migrating table issue
  756. type TIssue struct {
  757. ID int64 `xorm:"pk autoincr"`
  758. DeadlineUnix int64
  759. CreatedUnix int64
  760. UpdatedUnix int64
  761. }
  762. // TableName will be invoked by XORM to customrize the table name
  763. func (t *TIssue) TableName() string { return "issue" }
  764. // TMilestone defines the struct for migrating table milestone
  765. type TMilestone struct {
  766. ID int64 `xorm:"pk autoincr"`
  767. DeadlineUnix int64
  768. ClosedDateUnix int64
  769. }
  770. // TableName will be invoked by XORM to customrize the table name
  771. func (t *TMilestone) TableName() string { return "milestone" }
  772. // TAttachment defines the struct for migrating table attachment
  773. type TAttachment struct {
  774. ID int64 `xorm:"pk autoincr"`
  775. CreatedUnix int64
  776. }
  777. // TableName will be invoked by XORM to customrize the table name
  778. func (t *TAttachment) TableName() string { return "attachment" }
  779. // TLoginSource defines the struct for migrating table login_source
  780. type TLoginSource struct {
  781. ID int64 `xorm:"pk autoincr"`
  782. CreatedUnix int64
  783. UpdatedUnix int64
  784. }
  785. // TableName will be invoked by XORM to customrize the table name
  786. func (t *TLoginSource) TableName() string { return "login_source" }
  787. // TPull defines the struct for migrating table pull_request
  788. type TPull struct {
  789. ID int64 `xorm:"pk autoincr"`
  790. MergedUnix int64
  791. }
  792. // TableName will be invoked by XORM to customrize the table name
  793. func (t *TPull) TableName() string { return "pull_request" }
  794. // TRelease defines the struct for migrating table release
  795. type TRelease struct {
  796. ID int64 `xorm:"pk autoincr"`
  797. CreatedUnix int64
  798. }
  799. // TableName will be invoked by XORM to customrize the table name
  800. func (t *TRelease) TableName() string { return "release" }
  801. // TRepo defines the struct for migrating table repository
  802. type TRepo struct {
  803. ID int64 `xorm:"pk autoincr"`
  804. CreatedUnix int64
  805. UpdatedUnix int64
  806. }
  807. // TableName will be invoked by XORM to customrize the table name
  808. func (t *TRepo) TableName() string { return "repository" }
  809. // TMirror defines the struct for migrating table mirror
  810. type TMirror struct {
  811. ID int64 `xorm:"pk autoincr"`
  812. UpdatedUnix int64
  813. NextUpdateUnix int64
  814. }
  815. // TableName will be invoked by XORM to customrize the table name
  816. func (t *TMirror) TableName() string { return "mirror" }
  817. // TPublicKey defines the struct for migrating table public_key
  818. type TPublicKey struct {
  819. ID int64 `xorm:"pk autoincr"`
  820. CreatedUnix int64
  821. UpdatedUnix int64
  822. }
  823. // TableName will be invoked by XORM to customrize the table name
  824. func (t *TPublicKey) TableName() string { return "public_key" }
  825. // TDeployKey defines the struct for migrating table deploy_key
  826. type TDeployKey struct {
  827. ID int64 `xorm:"pk autoincr"`
  828. CreatedUnix int64
  829. UpdatedUnix int64
  830. }
  831. // TableName will be invoked by XORM to customrize the table name
  832. func (t *TDeployKey) TableName() string { return "deploy_key" }
  833. // TAccessToken defines the struct for migrating table access_token
  834. type TAccessToken struct {
  835. ID int64 `xorm:"pk autoincr"`
  836. CreatedUnix int64
  837. UpdatedUnix int64
  838. }
  839. // TableName will be invoked by XORM to customrize the table name
  840. func (t *TAccessToken) TableName() string { return "access_token" }
  841. // TUser defines the struct for migrating table user
  842. type TUser struct {
  843. ID int64 `xorm:"pk autoincr"`
  844. CreatedUnix int64
  845. UpdatedUnix int64
  846. }
  847. // TableName will be invoked by XORM to customrize the table name
  848. func (t *TUser) TableName() string { return "user" }
  849. // TWebhook defines the struct for migrating table webhook
  850. type TWebhook struct {
  851. ID int64 `xorm:"pk autoincr"`
  852. CreatedUnix int64
  853. UpdatedUnix int64
  854. }
  855. // TableName will be invoked by XORM to customrize the table name
  856. func (t *TWebhook) TableName() string { return "webhook" }
  857. func convertDateToUnix(x *xorm.Engine) (err error) {
  858. log.Info("This migration could take up to minutes, please be patient.")
  859. type Bean struct {
  860. ID int64 `xorm:"pk autoincr"`
  861. Created time.Time
  862. Updated time.Time
  863. Merged time.Time
  864. Deadline time.Time
  865. ClosedDate time.Time
  866. NextUpdate time.Time
  867. }
  868. var tables = []struct {
  869. name string
  870. cols []string
  871. bean interface{}
  872. }{
  873. {"action", []string{"created"}, new(TAction)},
  874. {"notice", []string{"created"}, new(TNotice)},
  875. {"comment", []string{"created"}, new(TComment)},
  876. {"issue", []string{"deadline", "created", "updated"}, new(TIssue)},
  877. {"milestone", []string{"deadline", "closed_date"}, new(TMilestone)},
  878. {"attachment", []string{"created"}, new(TAttachment)},
  879. {"login_source", []string{"created", "updated"}, new(TLoginSource)},
  880. {"pull_request", []string{"merged"}, new(TPull)},
  881. {"release", []string{"created"}, new(TRelease)},
  882. {"repository", []string{"created", "updated"}, new(TRepo)},
  883. {"mirror", []string{"updated", "next_update"}, new(TMirror)},
  884. {"public_key", []string{"created", "updated"}, new(TPublicKey)},
  885. {"deploy_key", []string{"created", "updated"}, new(TDeployKey)},
  886. {"access_token", []string{"created", "updated"}, new(TAccessToken)},
  887. {"user", []string{"created", "updated"}, new(TUser)},
  888. {"webhook", []string{"created", "updated"}, new(TWebhook)},
  889. }
  890. for _, table := range tables {
  891. log.Info("Converting table: %s", table.name)
  892. if err = x.Sync2(table.bean); err != nil {
  893. return fmt.Errorf("Sync [table: %s]: %v", table.name, err)
  894. }
  895. offset := 0
  896. for {
  897. beans := make([]*Bean, 0, 100)
  898. if err = x.Table(table.name).Asc("id").Limit(100, offset).Find(&beans); err != nil {
  899. return fmt.Errorf("select beans [table: %s, offset: %d]: %v", table.name, offset, err)
  900. }
  901. log.Trace("Table [%s]: offset: %d, beans: %d", table.name, offset, len(beans))
  902. if len(beans) == 0 {
  903. break
  904. }
  905. offset += 100
  906. baseSQL := "UPDATE `" + table.name + "` SET "
  907. for _, bean := range beans {
  908. valSQLs := make([]string, 0, len(table.cols))
  909. for _, col := range table.cols {
  910. fieldSQL := ""
  911. fieldSQL += col + "_unix = "
  912. switch col {
  913. case "deadline":
  914. if bean.Deadline.IsZero() {
  915. continue
  916. }
  917. fieldSQL += com.ToStr(bean.Deadline.Unix())
  918. case "created":
  919. fieldSQL += com.ToStr(bean.Created.Unix())
  920. case "updated":
  921. fieldSQL += com.ToStr(bean.Updated.Unix())
  922. case "closed_date":
  923. fieldSQL += com.ToStr(bean.ClosedDate.Unix())
  924. case "merged":
  925. fieldSQL += com.ToStr(bean.Merged.Unix())
  926. case "next_update":
  927. fieldSQL += com.ToStr(bean.NextUpdate.Unix())
  928. }
  929. valSQLs = append(valSQLs, fieldSQL)
  930. }
  931. if len(valSQLs) == 0 {
  932. continue
  933. }
  934. if _, err = x.Exec(baseSQL + strings.Join(valSQLs, ",") + " WHERE id = " + com.ToStr(bean.ID)); err != nil {
  935. return fmt.Errorf("update bean [table: %s, id: %d]: %v", table.name, bean.ID, err)
  936. }
  937. }
  938. }
  939. }
  940. return nil
  941. }