You can not select more than 25 topics Topics must start with a chinese character,a letter or number, can include dashes ('-') and can be up to 35 characters long.

issue_milestone.go 11 kB

Shows total tracked time in issue and milestone list (#3341) * Show total tracked time in issue and milestone list Show total tracked time at issue page Signed-off-by: Jonas Franz <info@jonasfranz.software> * Optimizing TotalTimes by using SumInt Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fixing wrong total times for milestones caused by a missing JOIN Adding unit tests for total times Signed-off-by: Jonas Franz <info@jonasfranz.software> * Logging error instead of ignoring it Signed-off-by: Jonas Franz <info@jonasfranz.software> * Correcting spelling mistakes Signed-off-by: Jonas Franz <info@jonasfranz.software> * Change error message to a short version Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add error handling to TotalTimes Add variable for totalTimes Signed-off-by: Jonas Franz <info@jonasfranz.de> * Introduce TotalTrackedTimes as variable of issue Load TotalTrackedTimes by loading attributes of IssueList Load TotalTrackedTimes by loading attributes of single issue Add Sec2Time as helper to use it in templates Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fixed test + gofmt Signed-off-by: Jonas Franz <info@jonasfranz.software> * Load TotalTrackedTimes via MilestoneList instead of single requests Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add documentation for MilestoneList Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add documentation for MilestoneList Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix test Signed-off-by: Jonas Franz <info@jonasfranz.software> * Change comment from SQL query to description Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix unit test by using int64 instead of int Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix unit test by using int64 instead of int Signed-off-by: Jonas Franz <info@jonasfranz.software> * Check if timetracker is enabled Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix test by enabling timetracking Signed-off-by: Jonas Franz <info@jonasfranz.de>
7 years ago
Shows total tracked time in issue and milestone list (#3341) * Show total tracked time in issue and milestone list Show total tracked time at issue page Signed-off-by: Jonas Franz <info@jonasfranz.software> * Optimizing TotalTimes by using SumInt Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fixing wrong total times for milestones caused by a missing JOIN Adding unit tests for total times Signed-off-by: Jonas Franz <info@jonasfranz.software> * Logging error instead of ignoring it Signed-off-by: Jonas Franz <info@jonasfranz.software> * Correcting spelling mistakes Signed-off-by: Jonas Franz <info@jonasfranz.software> * Change error message to a short version Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add error handling to TotalTimes Add variable for totalTimes Signed-off-by: Jonas Franz <info@jonasfranz.de> * Introduce TotalTrackedTimes as variable of issue Load TotalTrackedTimes by loading attributes of IssueList Load TotalTrackedTimes by loading attributes of single issue Add Sec2Time as helper to use it in templates Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fixed test + gofmt Signed-off-by: Jonas Franz <info@jonasfranz.software> * Load TotalTrackedTimes via MilestoneList instead of single requests Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add documentation for MilestoneList Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add documentation for MilestoneList Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix test Signed-off-by: Jonas Franz <info@jonasfranz.software> * Change comment from SQL query to description Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix unit test by using int64 instead of int Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix unit test by using int64 instead of int Signed-off-by: Jonas Franz <info@jonasfranz.software> * Check if timetracker is enabled Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix test by enabling timetracking Signed-off-by: Jonas Franz <info@jonasfranz.de>
7 years ago
Shows total tracked time in issue and milestone list (#3341) * Show total tracked time in issue and milestone list Show total tracked time at issue page Signed-off-by: Jonas Franz <info@jonasfranz.software> * Optimizing TotalTimes by using SumInt Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fixing wrong total times for milestones caused by a missing JOIN Adding unit tests for total times Signed-off-by: Jonas Franz <info@jonasfranz.software> * Logging error instead of ignoring it Signed-off-by: Jonas Franz <info@jonasfranz.software> * Correcting spelling mistakes Signed-off-by: Jonas Franz <info@jonasfranz.software> * Change error message to a short version Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add error handling to TotalTimes Add variable for totalTimes Signed-off-by: Jonas Franz <info@jonasfranz.de> * Introduce TotalTrackedTimes as variable of issue Load TotalTrackedTimes by loading attributes of IssueList Load TotalTrackedTimes by loading attributes of single issue Add Sec2Time as helper to use it in templates Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fixed test + gofmt Signed-off-by: Jonas Franz <info@jonasfranz.software> * Load TotalTrackedTimes via MilestoneList instead of single requests Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add documentation for MilestoneList Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add documentation for MilestoneList Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix test Signed-off-by: Jonas Franz <info@jonasfranz.software> * Change comment from SQL query to description Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix unit test by using int64 instead of int Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix unit test by using int64 instead of int Signed-off-by: Jonas Franz <info@jonasfranz.software> * Check if timetracker is enabled Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix test by enabling timetracking Signed-off-by: Jonas Franz <info@jonasfranz.de>
7 years ago
123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446
  1. // Copyright 2017 The Gitea Authors. All rights reserved.
  2. // Use of this source code is governed by a MIT-style
  3. // license that can be found in the LICENSE file.
  4. package models
  5. import (
  6. "fmt"
  7. "code.gitea.io/gitea/modules/setting"
  8. api "code.gitea.io/gitea/modules/structs"
  9. "code.gitea.io/gitea/modules/timeutil"
  10. "github.com/go-xorm/xorm"
  11. )
  12. // Milestone represents a milestone of repository.
  13. type Milestone struct {
  14. ID int64 `xorm:"pk autoincr"`
  15. RepoID int64 `xorm:"INDEX"`
  16. Name string
  17. Content string `xorm:"TEXT"`
  18. RenderedContent string `xorm:"-"`
  19. IsClosed bool
  20. NumIssues int
  21. NumClosedIssues int
  22. NumOpenIssues int `xorm:"-"`
  23. Completeness int // Percentage(1-100).
  24. IsOverdue bool `xorm:"-"`
  25. DeadlineString string `xorm:"-"`
  26. DeadlineUnix timeutil.TimeStamp
  27. ClosedDateUnix timeutil.TimeStamp
  28. TotalTrackedTime int64 `xorm:"-"`
  29. }
  30. // BeforeUpdate is invoked from XORM before updating this object.
  31. func (m *Milestone) BeforeUpdate() {
  32. if m.NumIssues > 0 {
  33. m.Completeness = m.NumClosedIssues * 100 / m.NumIssues
  34. } else {
  35. m.Completeness = 0
  36. }
  37. }
  38. // AfterLoad is invoked from XORM after setting the value of a field of
  39. // this object.
  40. func (m *Milestone) AfterLoad() {
  41. m.NumOpenIssues = m.NumIssues - m.NumClosedIssues
  42. if m.DeadlineUnix.Year() == 9999 {
  43. return
  44. }
  45. m.DeadlineString = m.DeadlineUnix.Format("2006-01-02")
  46. if timeutil.TimeStampNow() >= m.DeadlineUnix {
  47. m.IsOverdue = true
  48. }
  49. }
  50. // State returns string representation of milestone status.
  51. func (m *Milestone) State() api.StateType {
  52. if m.IsClosed {
  53. return api.StateClosed
  54. }
  55. return api.StateOpen
  56. }
  57. // APIFormat returns this Milestone in API format.
  58. func (m *Milestone) APIFormat() *api.Milestone {
  59. apiMilestone := &api.Milestone{
  60. ID: m.ID,
  61. State: m.State(),
  62. Title: m.Name,
  63. Description: m.Content,
  64. OpenIssues: m.NumOpenIssues,
  65. ClosedIssues: m.NumClosedIssues,
  66. }
  67. if m.IsClosed {
  68. apiMilestone.Closed = m.ClosedDateUnix.AsTimePtr()
  69. }
  70. if m.DeadlineUnix.Year() < 9999 {
  71. apiMilestone.Deadline = m.DeadlineUnix.AsTimePtr()
  72. }
  73. return apiMilestone
  74. }
  75. // NewMilestone creates new milestone of repository.
  76. func NewMilestone(m *Milestone) (err error) {
  77. sess := x.NewSession()
  78. defer sess.Close()
  79. if err = sess.Begin(); err != nil {
  80. return err
  81. }
  82. if _, err = sess.Insert(m); err != nil {
  83. return err
  84. }
  85. if _, err = sess.Exec("UPDATE `repository` SET num_milestones = num_milestones + 1 WHERE id = ?", m.RepoID); err != nil {
  86. return err
  87. }
  88. return sess.Commit()
  89. }
  90. func getMilestoneByRepoID(e Engine, repoID, id int64) (*Milestone, error) {
  91. m := &Milestone{
  92. ID: id,
  93. RepoID: repoID,
  94. }
  95. has, err := e.Get(m)
  96. if err != nil {
  97. return nil, err
  98. } else if !has {
  99. return nil, ErrMilestoneNotExist{id, repoID}
  100. }
  101. return m, nil
  102. }
  103. // GetMilestoneByRepoID returns the milestone in a repository.
  104. func GetMilestoneByRepoID(repoID, id int64) (*Milestone, error) {
  105. return getMilestoneByRepoID(x, repoID, id)
  106. }
  107. // GetMilestoneByID returns the milestone via id .
  108. func GetMilestoneByID(id int64) (*Milestone, error) {
  109. var m Milestone
  110. has, err := x.ID(id).Get(&m)
  111. if err != nil {
  112. return nil, err
  113. } else if !has {
  114. return nil, ErrMilestoneNotExist{id, 0}
  115. }
  116. return &m, nil
  117. }
  118. // MilestoneList is a list of milestones offering additional functionality
  119. type MilestoneList []*Milestone
  120. func (milestones MilestoneList) loadTotalTrackedTimes(e Engine) error {
  121. type totalTimesByMilestone struct {
  122. MilestoneID int64
  123. Time int64
  124. }
  125. if len(milestones) == 0 {
  126. return nil
  127. }
  128. var trackedTimes = make(map[int64]int64, len(milestones))
  129. // Get total tracked time by milestone_id
  130. rows, err := e.Table("issue").
  131. Join("INNER", "milestone", "issue.milestone_id = milestone.id").
  132. Join("LEFT", "tracked_time", "tracked_time.issue_id = issue.id").
  133. Select("milestone_id, sum(time) as time").
  134. In("milestone_id", milestones.getMilestoneIDs()).
  135. GroupBy("milestone_id").
  136. Rows(new(totalTimesByMilestone))
  137. if err != nil {
  138. return err
  139. }
  140. defer rows.Close()
  141. for rows.Next() {
  142. var totalTime totalTimesByMilestone
  143. err = rows.Scan(&totalTime)
  144. if err != nil {
  145. return err
  146. }
  147. trackedTimes[totalTime.MilestoneID] = totalTime.Time
  148. }
  149. for _, milestone := range milestones {
  150. milestone.TotalTrackedTime = trackedTimes[milestone.ID]
  151. }
  152. return nil
  153. }
  154. // LoadTotalTrackedTimes loads for every milestone in the list the TotalTrackedTime by a batch request
  155. func (milestones MilestoneList) LoadTotalTrackedTimes() error {
  156. return milestones.loadTotalTrackedTimes(x)
  157. }
  158. func (milestones MilestoneList) getMilestoneIDs() []int64 {
  159. var ids = make([]int64, 0, len(milestones))
  160. for _, ms := range milestones {
  161. ids = append(ids, ms.ID)
  162. }
  163. return ids
  164. }
  165. // GetMilestonesByRepoID returns all opened milestones of a repository.
  166. func GetMilestonesByRepoID(repoID int64, state api.StateType) (MilestoneList, error) {
  167. sess := x.Where("repo_id = ?", repoID)
  168. switch state {
  169. case api.StateClosed:
  170. sess = sess.And("is_closed = ?", true)
  171. case api.StateAll:
  172. break
  173. case api.StateOpen:
  174. fallthrough
  175. default:
  176. sess = sess.And("is_closed = ?", false)
  177. }
  178. miles := make([]*Milestone, 0, 10)
  179. return miles, sess.Asc("deadline_unix").Asc("id").Find(&miles)
  180. }
  181. // GetMilestones returns a list of milestones of given repository and status.
  182. func GetMilestones(repoID int64, page int, isClosed bool, sortType string) (MilestoneList, error) {
  183. miles := make([]*Milestone, 0, setting.UI.IssuePagingNum)
  184. sess := x.Where("repo_id = ? AND is_closed = ?", repoID, isClosed)
  185. if page > 0 {
  186. sess = sess.Limit(setting.UI.IssuePagingNum, (page-1)*setting.UI.IssuePagingNum)
  187. }
  188. switch sortType {
  189. case "furthestduedate":
  190. sess.Desc("deadline_unix")
  191. case "leastcomplete":
  192. sess.Asc("completeness")
  193. case "mostcomplete":
  194. sess.Desc("completeness")
  195. case "leastissues":
  196. sess.Asc("num_issues")
  197. case "mostissues":
  198. sess.Desc("num_issues")
  199. default:
  200. sess.Asc("deadline_unix")
  201. }
  202. return miles, sess.Find(&miles)
  203. }
  204. func updateMilestone(e Engine, m *Milestone) error {
  205. _, err := e.ID(m.ID).AllCols().Update(m)
  206. return err
  207. }
  208. // UpdateMilestone updates information of given milestone.
  209. func UpdateMilestone(m *Milestone) error {
  210. return updateMilestone(x, m)
  211. }
  212. func countRepoMilestones(e Engine, repoID int64) (int64, error) {
  213. return e.
  214. Where("repo_id=?", repoID).
  215. Count(new(Milestone))
  216. }
  217. func countRepoClosedMilestones(e Engine, repoID int64) (int64, error) {
  218. return e.
  219. Where("repo_id=? AND is_closed=?", repoID, true).
  220. Count(new(Milestone))
  221. }
  222. // CountRepoClosedMilestones returns number of closed milestones in given repository.
  223. func CountRepoClosedMilestones(repoID int64) (int64, error) {
  224. return countRepoClosedMilestones(x, repoID)
  225. }
  226. // MilestoneStats returns number of open and closed milestones of given repository.
  227. func MilestoneStats(repoID int64) (open int64, closed int64, err error) {
  228. open, err = x.
  229. Where("repo_id=? AND is_closed=?", repoID, false).
  230. Count(new(Milestone))
  231. if err != nil {
  232. return 0, 0, nil
  233. }
  234. closed, err = CountRepoClosedMilestones(repoID)
  235. return open, closed, err
  236. }
  237. // ChangeMilestoneStatus changes the milestone open/closed status.
  238. func ChangeMilestoneStatus(m *Milestone, isClosed bool) (err error) {
  239. repo, err := GetRepositoryByID(m.RepoID)
  240. if err != nil {
  241. return err
  242. }
  243. sess := x.NewSession()
  244. defer sess.Close()
  245. if err = sess.Begin(); err != nil {
  246. return err
  247. }
  248. m.IsClosed = isClosed
  249. if err = updateMilestone(sess, m); err != nil {
  250. return err
  251. }
  252. numMilestones, err := countRepoMilestones(sess, repo.ID)
  253. if err != nil {
  254. return err
  255. }
  256. numClosedMilestones, err := countRepoClosedMilestones(sess, repo.ID)
  257. if err != nil {
  258. return err
  259. }
  260. repo.NumMilestones = int(numMilestones)
  261. repo.NumClosedMilestones = int(numClosedMilestones)
  262. if _, err = sess.ID(repo.ID).Cols("num_milestones, num_closed_milestones").Update(repo); err != nil {
  263. return err
  264. }
  265. return sess.Commit()
  266. }
  267. func updateMilestoneTotalNum(e Engine, milestoneID int64) (err error) {
  268. if _, err = e.Exec("UPDATE `milestone` SET num_issues=(SELECT count(*) FROM issue WHERE milestone_id=?) WHERE id=?",
  269. milestoneID,
  270. milestoneID,
  271. ); err != nil {
  272. return
  273. }
  274. _, err = e.Exec("UPDATE `milestone` SET completeness=100*num_closed_issues/(CASE WHEN num_issues > 0 THEN num_issues ELSE 1 END) WHERE id=?",
  275. milestoneID,
  276. )
  277. return
  278. }
  279. func updateMilestoneClosedNum(e Engine, milestoneID int64) (err error) {
  280. if _, err = e.Exec("UPDATE `milestone` SET num_closed_issues=(SELECT count(*) FROM issue WHERE milestone_id=? AND is_closed=?) WHERE id=?",
  281. milestoneID,
  282. true,
  283. milestoneID,
  284. ); err != nil {
  285. return
  286. }
  287. _, err = e.Exec("UPDATE `milestone` SET completeness=100*num_closed_issues/(CASE WHEN num_issues > 0 THEN num_issues ELSE 1 END) WHERE id=?",
  288. milestoneID,
  289. )
  290. return
  291. }
  292. func changeMilestoneAssign(e *xorm.Session, doer *User, issue *Issue, oldMilestoneID int64) error {
  293. if err := updateIssueCols(e, issue, "milestone_id"); err != nil {
  294. return err
  295. }
  296. if oldMilestoneID > 0 {
  297. if err := updateMilestoneTotalNum(e, oldMilestoneID); err != nil {
  298. return err
  299. }
  300. if issue.IsClosed {
  301. if err := updateMilestoneClosedNum(e, oldMilestoneID); err != nil {
  302. return err
  303. }
  304. }
  305. }
  306. if issue.MilestoneID > 0 {
  307. if err := updateMilestoneTotalNum(e, issue.MilestoneID); err != nil {
  308. return err
  309. }
  310. if issue.IsClosed {
  311. if err := updateMilestoneClosedNum(e, issue.MilestoneID); err != nil {
  312. return err
  313. }
  314. }
  315. }
  316. if oldMilestoneID > 0 || issue.MilestoneID > 0 {
  317. if err := issue.loadRepo(e); err != nil {
  318. return err
  319. }
  320. if _, err := createMilestoneComment(e, doer, issue.Repo, issue, oldMilestoneID, issue.MilestoneID); err != nil {
  321. return err
  322. }
  323. }
  324. return nil
  325. }
  326. // ChangeMilestoneAssign changes assignment of milestone for issue.
  327. func ChangeMilestoneAssign(issue *Issue, doer *User, oldMilestoneID int64) (err error) {
  328. sess := x.NewSession()
  329. defer sess.Close()
  330. if err = sess.Begin(); err != nil {
  331. return err
  332. }
  333. if err = changeMilestoneAssign(sess, doer, issue, oldMilestoneID); err != nil {
  334. return err
  335. }
  336. if err = sess.Commit(); err != nil {
  337. return fmt.Errorf("Commit: %v", err)
  338. }
  339. return nil
  340. }
  341. // DeleteMilestoneByRepoID deletes a milestone from a repository.
  342. func DeleteMilestoneByRepoID(repoID, id int64) error {
  343. m, err := GetMilestoneByRepoID(repoID, id)
  344. if err != nil {
  345. if IsErrMilestoneNotExist(err) {
  346. return nil
  347. }
  348. return err
  349. }
  350. repo, err := GetRepositoryByID(m.RepoID)
  351. if err != nil {
  352. return err
  353. }
  354. sess := x.NewSession()
  355. defer sess.Close()
  356. if err = sess.Begin(); err != nil {
  357. return err
  358. }
  359. if _, err = sess.ID(m.ID).Delete(new(Milestone)); err != nil {
  360. return err
  361. }
  362. numMilestones, err := countRepoMilestones(sess, repo.ID)
  363. if err != nil {
  364. return err
  365. }
  366. numClosedMilestones, err := countRepoClosedMilestones(sess, repo.ID)
  367. if err != nil {
  368. return err
  369. }
  370. repo.NumMilestones = int(numMilestones)
  371. repo.NumClosedMilestones = int(numClosedMilestones)
  372. if _, err = sess.ID(repo.ID).Cols("num_milestones, num_closed_milestones").Update(repo); err != nil {
  373. return err
  374. }
  375. if _, err = sess.Exec("UPDATE `issue` SET milestone_id = 0 WHERE milestone_id = ?", m.ID); err != nil {
  376. return err
  377. }
  378. return sess.Commit()
  379. }