Optimize getty config (#430)

* temporary not supported connection-num

conf/config.yaml

@@ -1,54 +0,0 @@
-#
-# Licensed to the Apache Software Foundation (ASF) under one or more
-# contributor license agreements.  See the NOTICE file distributed with
-# this work for additional information regarding copyright ownership.
-# The ASF licenses this file to You under the Apache License, Version 2.0
-# (the "License"); you may not use this file except in compliance with
-# the License.  You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-
-# 配置类;io.seata.spring.boot.autoconfigure.StarterConstants
-
-seata:
-  transport:
-    type: "TCP"
-    #NIO NATIVE
-    server: "NIO"
-    #enable heartbeat
-    heartbeat: true
-    # the client batch send request enable
-    enableClientBatchSendRequest: true
-    compressor: none
-  service:
-    
-  
-  client:
-    rm:
-      asyncCommitBufferLimit: 10000
-      reportRetryCount: 5
-      tableMetaCheckEnable: false
-      reportSuccessEnable: false
-      sagaBranchRegisterEnable: 10000
-      sagaJsonParser: fastjson
-      sagaRetryPersistModeUpdate: false
-      sagaCompensatePersistModeUpdate: false
-    tm:
-      commitRetryCount: 5
-      rollbackRetryCount: 5
-      defaultGlobalTransactionTimeout: 60000
-      degradeCheck: false
-      degradeCheckAllowTimes: 10
-      degradeCheckPeriod: 2000
-    undo:
-      dataValidation: true
-      logSerialization: jackson
-      logTable: undo_log
-      onlyCareUpdateColumns: true

conf/seata_config.yml

@@ -1,156 +0,0 @@
-# Licensed to the Apache Software Foundation (ASF) under one or more
-# contributor license agreements.  See the NOTICE file distributed with
-# this work for additional information regarding copyright ownership.
-# The ASF licenses this file to You under the Apache License, Version 2.0
-# (the "License"); you may not use this file except in compliance with
-# the License.  You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-
-# time 时间单位对应的是 time.Duration(1)
-seata:
-  enabled: true
-  # application id
-  application-id: applicationName
-  # service group
-  tx-service-group: default_tx_group
-  access-key: aliyunAccessKey
-  secret-key: aliyunSecretKey
-  enable-auto-data-source-proxy: true
-  data-source-proxy-mode: AT
-  client:
-    rm:
-      # Maximum cache length of asynchronous queue
-      async-commit-buffer-limit: 10000
-      # The maximum number of retries when report reports the status
-      report-retry-count: 5
-      # The interval for regularly checking the metadata of the db（AT）
-      table-meta-check-enable: false
-      # Whether to report the status if the transaction is successfully executed（AT）
-      report-success-enable: false
-      # Whether to allow regular check of db metadata（AT）
-      saga-branch-register-enable: false
-      saga-json-parser: fastjson
-      saga-retry-persist-mode-update: false
-      saga-compensate-persist-mode-update: false
-      #Ordered.HIGHEST_PRECEDENCE + 1000  #
-      tcc-action-interceptor-order: -2147482648
-      # Parse SQL parser selection
-      sql-parser-type: druid
-      lock:
-        retry-interval: 10
-        retry-times: 30s
-        retry-policy-branch-rollback-on-conflict: true
-    tm:
-      commit-retry-count: 5
-      rollback-retry-count: 5
-      default-global-transaction-timeout: 10s
-      degrade-check: false
-      degrade-check-period: 2000
-      degrade-check-allow-times: 10s
-      interceptor-order: -2147482648
-    undo:
-      # Judge whether the before image and after image are the same，If it is the same, undo will not be recorded
-      data-validation: true
-      # Serialization method
-      log-serialization: jackson
-      # undo log table name
-      log-table: undo_log
-      # Only store modified fields
-      only-care-update-columns: true
-      compress:
-        # Whether compression is required
-        enable: true
-        # Compression type
-        type: zip
-        #  Compression threshold Unit: k
-        threshold: 64
-    load-balance:
-      type: RandomLoadBalance
-      virtual-nodes: 10
-  service:
-    vgroup-mapping:
-      # Prefix for Print Log
-      default_tx_group: default
-    grouplist:
-      default: 127.0.0.1:8091
-    enable-degrade: false
-    # close the transaction
-    disable-global-transaction: false
-  transport:
-    shutdown:
-      wait: 3s
-    # Netty related configurations
-    # type
-    type: TCP
-    server: NIO
-    heartbeat: true
-    # Encoding and decoding mode
-    serialization: seata
-    # Message compression mode
-    compressor: none
-    # Allow batch sending of requests (TM)
-    enable-tm-client-batch-send-request: false
-    # Allow batch sending of requests (RM)
-    enable-rm-client-batch-send-request: true
-    # RM send request timeout
-    rpc-rm-request-timeout: 30s
-    # TM send request timeout
-    rpc-tm-request-timeout: 30s
-  # Configuration Center
-  config:
-    type: file
-    file:
-      name: config.conf
-    nacos:
-      namespace: ""
-      server-addr: 127.0.0.1:8848
-      group: SEATA_GROUP
-      username: ""
-      password: ""
-      ##if use MSE Nacos with auth, mutex with username/password attribute
-      #access-key: ""
-      #secret-key: ""
-      data-id: seata.properties
-  # Registration Center
-  registry:
-    type: file
-    file:
-      name: registry.conf
-    nacos:
-      application: seata-server
-      server-addr: 127.0.0.1:8848
-      group: "SEATA_GROUP"
-      namespace: ""
-      username: ""
-      password: ""
-      ##if use MSE Nacos with auth, mutex with username/password attribute  #
-      #access-key: ""  #
-      #secret-key: ""  #
-  log:
-    exception-rate: 100
-  tcc:
-    fence:
-      # Anti suspension table name
-      log-table-name: tcc_fence_log
-
-      clean-period: 60s
-  # getty configuration
-  getty-session-param:
-    compress-encoding: false
-    tcp-no-delay: true
-    tcp-keep-alive: true
-    keep-alive-period: 120s
-    tcp-r-buf-size: 262144
-    tcp-w-buf-size: 65536
-    tcp-read-timeout: 1s
-    tcp-write-timeout: 5s
-    wait-timeout: 1s
-    max-msg-len: 16498688
-    session-name: client

pkg/client/config_test.go

@@ -79,7 +79,7 @@ func TestLoadPath(t *testing.T) {
 	assert.NotNil(t, cfg.GettyConfig)
 	assert.NotNil(t, cfg.GettyConfig.SessionConfig)
 	assert.Equal(t, 0, cfg.GettyConfig.ReconnectInterval)
-	assert.Equal(t, 16, cfg.GettyConfig.ConnectionNum)
+	assert.Equal(t, 1, cfg.GettyConfig.ConnectionNum)
 	assert.Equal(t, false, cfg.GettyConfig.SessionConfig.CompressEncoding)
 	assert.Equal(t, true, cfg.GettyConfig.SessionConfig.TCPNoDelay)
 	assert.Equal(t, true, cfg.GettyConfig.SessionConfig.TCPKeepAlive)

pkg/remoting/getty/config.go

@@ -54,7 +54,7 @@ type TransportConfig struct {
 // RegisterFlagsWithPrefix for Config.
 func (cfg *Config) RegisterFlagsWithPrefix(prefix string, f *flag.FlagSet) {
 	f.IntVar(&cfg.ReconnectInterval, prefix+".reconnect-interval", 0, "Reconnect interval.")
-	f.IntVar(&cfg.ConnectionNum, prefix+".connection-num", 16, "The getty_session pool.")
+	f.IntVar(&cfg.ConnectionNum, prefix+".connection-num", 1, "The getty_session pool.")
 	cfg.SessionConfig.RegisterFlagsWithPrefix(prefix+".session", f)
 }
 

pkg/remoting/getty/rpc_client.go

@@ -58,7 +58,8 @@ func (c *RpcClient) init() {
 	for _, address := range addressList {
 		gettyClient := getty.NewTCPClient(
 			getty.WithServerAddress(address),
-			getty.WithConnectionNumber(c.gettyConf.ConnectionNum),
+			// todo if read c.gettyConf.ConnectionNum, will cause the connect to fail
+			getty.WithConnectionNumber(1),
 			getty.WithReconnectInterval(c.gettyConf.ReconnectInterval),
 			getty.WithClientTaskPool(gxsync.NewTaskPoolSimple(0)),
 		)

sample/conf/seatago.yml

@@ -143,8 +143,8 @@ seata:
   # getty configuration
   getty:
     reconnect-interval: 0
+    # temporary not supported connection-num
     connection-num: 1
-    heartbeat-period: 15s
     session:
       compress-encoding: false
       tcp-no-delay: true

testdata/conf/seatago.yml

@@ -143,7 +143,8 @@ seata:
   # getty configuration
   getty:
     reconnect-interval: 0
-    connection-num: 16
+    # temporary not supported connection-num
+    connection-num: 1
     session:
       compress-encoding: false
       tcp-no-delay: true