Browse Source

Close file on error path.

The file was only be closed when there was no error and
was being left open when there was an error. By moving
the close(fd) statement out of the if-clause, the file
can be close regardless if there is an error or not.
After the file is closed, it can be checked for errors.
tags/json-c-0.16-20220414
Kizuna-Meraki 3 years ago
parent
commit
d783ad76c7
1 changed files with 3 additions and 1 deletions
  1. +3
    -1
      random_seed.c

+ 3
- 1
random_seed.c View File

@@ -237,13 +237,15 @@ static int get_dev_random_seed(int *seed)
}

ssize_t nread = read(fd, seed, sizeof(*seed));

close(fd);

if (nread != sizeof(*seed))
{
fprintf(stderr, "error short read %s: %s", dev_random_file, strerror(errno));
return -1;
}

close(fd);
return 0;
}



Loading…
Cancel
Save