From f17343e19b8c1070b98a82dc2a0e7bb0622f7572 Mon Sep 17 00:00:00 2001 From: ROGERDJQ Date: Wed, 16 Dec 2020 18:04:22 +0800 Subject: [PATCH 1/2] =?UTF-8?q?[bugfix]=E4=BF=AE=E5=A4=8Dfitlogcallback?= =?UTF-8?q?=E5=9C=A8disttrainner=E4=B8=AD=E6=97=A0=E6=B3=95=E6=B7=BB?= =?UTF-8?q?=E5=8A=A0dev=5Fdata=20=E7=9A=84=E9=97=AE=E9=A2=98=20(#348)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit fix the distTrainer dev_data --- fastNLP/core/dist_trainer.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/fastNLP/core/dist_trainer.py b/fastNLP/core/dist_trainer.py index 35970581..a26673b2 100644 --- a/fastNLP/core/dist_trainer.py +++ b/fastNLP/core/dist_trainer.py @@ -177,8 +177,13 @@ class DistTrainer(): self.batch_size = self.world_size * self.batch_size_per_gpu self.n_steps = self._get_n_steps() + self.dev_data = dev_data + self.metrics = metrics + self.test_use_tqdm = True + self.kwargs = kwargs self.test_use_tqdm = kwargs.get('test_use_tqdm', self.use_tqdm) dev_batch_size = kwargs.get('dev_batch_size', batch_size_per_gpu) + # for evaluation, only run eval on master proc if dev_data and metrics: cb = _TesterCallback( From 2b91830c2617e829270b59c0f1ac1aff53a943d6 Mon Sep 17 00:00:00 2001 From: sleepy-owl <61391995+sleepy-owl@users.noreply.github.com> Date: Tue, 23 Feb 2021 05:04:05 -0600 Subject: [PATCH 2/2] Flaky test fix (#352) --- tests/core/test_batch.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/core/test_batch.py b/tests/core/test_batch.py index 7bdcbda7..1e218800 100644 --- a/tests/core/test_batch.py +++ b/tests/core/test_batch.py @@ -445,7 +445,7 @@ class TestCase1(unittest.TestCase): sample_count = 0 for batch_x, batch_y in data_iter: sample_count += len(batch_x['seq_len']) - self.assertTrue(sum(batch_x['seq_len'])<120) + self.assertTrue(sum(batch_x['seq_len'])<=120) self.assertEqual(sample_count, num_samples) """