Browse Source

Re-enable loop unrolling in trmv and remove the scary warning

fixes #1748 as that half of the fix for #1332 appears to have been an overreaction on my part.
tags/v0.3.5
Martin Kroeker GitHub 7 years ago
parent
commit
5a720cf9ca
No known key found for this signature in database GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 7 deletions
  1. +3
    -7
      driver/level2/trmv_U.c

+ 3
- 7
driver/level2/trmv_U.c View File

@@ -54,16 +54,12 @@ int CNAME(BLASLONG m, FLOAT *a, BLASLONG lda, FLOAT *b, BLASLONG incb, FLOAT *bu
COPY_K(m, b, incb, buffer, 1); COPY_K(m, b, incb, buffer, 1);
} }


/*FIXME the GEMV unrolling performed here was found to be broken, see issue 1332 */
/* Multiplying DTB size by 100 is just a quick-and-dirty hack to disable it for now[B */
for (is = 0; is < m; is += DTB_ENTRIES){


for (is = 0; is < m; is += DTB_ENTRIES * 100){

min_i = MIN(m - is, DTB_ENTRIES * 100);
min_i = MIN(m - is, DTB_ENTRIES);


#ifndef TRANSA #ifndef TRANSA
if (is > 0){
fprintf(stderr,"WARNING unrolling of the trmv_U loop may give wrong results\n");
if (is > 0){
GEMV_N(is, min_i, 0, dp1, GEMV_N(is, min_i, 0, dp1,
a + is * lda, lda, a + is * lda, lda,
B + is, 1, B + is, 1,


Loading…
Cancel
Save