From 51ba70f47bba6b7a161f61526a2f196fe896e1f6 Mon Sep 17 00:00:00 2001 From: Harmen Stoppels Date: Thu, 10 Apr 2025 15:20:34 +0200 Subject: [PATCH] test_potrs.c: remove pragma darwin-aarch64 support Using GCC 14.2.0 on Darwin, the pragma ultimately causes a linker error "ld: invalid r_symbolnum=". The current workaround is to use the old linker, but (a) it's deprecated and (b) it can produce libraries that are subsequently not linkable with the newer linker in dependents: the new ld64 does not link to libraries with duplicate rpaths created by the classic linker. --- Makefile.system | 4 ---- utest/test_potrs.c | 1 - 2 files changed, 5 deletions(-) diff --git a/Makefile.system b/Makefile.system index 79544276b..ac6a41c92 100644 --- a/Makefile.system +++ b/Makefile.system @@ -436,10 +436,6 @@ CCOMMON_OPT += -Wl,-ld_classic FCOMMON_OPT += -Wl,-ld_classic endif ifeq (x$(XCVER), x 16) -ifeq ($(C_COMPILER), GCC) -CCOMMON_OPT += -Wl,-ld_classic -FCOMMON_OPT += -Wl,-ld_classic -endif ifeq ($(F_COMPILER), GFORTRAN) override CEXTRALIB := $(filter-out(-lto_library, $(CEXTRALIB))) endif diff --git a/utest/test_potrs.c b/utest/test_potrs.c index 642ce1e37..e6ccf4bb6 100644 --- a/utest/test_potrs.c +++ b/utest/test_potrs.c @@ -32,7 +32,6 @@ USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. **********************************************************************************/ #include "openblas_utest.h" -#pragma GCC optimize("no-gcse") /* void BLASFUNC(cpotrf)(char*, BLASINT*, complex float*, BLASINT*, BLASINT*); void BLASFUNC(zpotrs_(char*, BLASINT*, BLASINT*, complex double*,