From dc6e84bf2f6edf42f4ad131ef2f025925ba6e5c1 Mon Sep 17 00:00:00 2001 From: jiangshuqiang <962978787@qq.com> Date: Tue, 3 Nov 2020 10:21:30 +0800 Subject: [PATCH] fix the rule of reporting crc length warning --- .../data_transform/ms_data_loader.py | 19 +++++-------------- 1 file changed, 5 insertions(+), 14 deletions(-) diff --git a/mindinsight/datavisual/data_transform/ms_data_loader.py b/mindinsight/datavisual/data_transform/ms_data_loader.py index d1d03039..a97a0152 100644 --- a/mindinsight/datavisual/data_transform/ms_data_loader.py +++ b/mindinsight/datavisual/data_transform/ms_data_loader.py @@ -20,7 +20,6 @@ Each instance will read an entire run, a run can contain one or more log file. """ import re -import time import struct from google.protobuf.message import DecodeError @@ -47,7 +46,6 @@ from mindinsight.utils.exceptions import UnknownError HEADER_SIZE = 8 CRC_STR_SIZE = 4 MAX_EVENT_STRING = 500000000 -RETRY_TIMES = 2 class MSDataLoader: @@ -370,12 +368,10 @@ class _SummaryParser(_Parser): Returns: bool, True if the summary file is finished loading. """ - crc_check_time = 0 while True: start_offset = file_handler.offset try: event_str = self._event_load(file_handler) - crc_check_time = 0 if event_str is None: file_handler.reset_offset(start_offset) return True @@ -404,17 +400,12 @@ class _SummaryParser(_Parser): future.add_done_callback(exception_no_raise_wrapper(_add_tensor_event_callback)) return False except exceptions.CRCLengthFailedError: - if crc_check_time > RETRY_TIMES: - logger.warning( - "Check crc length failed, please check the summary file integrity, " - "the file may be in transfer, file_path: %s, offset=%s.", - file_handler.file_path, start_offset) - return True - logger.info( - "Check crc failed, retrying %d/%d times.", crc_check_time + 1, RETRY_TIMES + 1) file_handler.reset_offset(start_offset) - crc_check_time += 1 - time.sleep(0.5) + logger.warning( + "Check crc length failed, please check the summary file integrity, " + "the file may be in transfer, file_path: %s, offset=%s.", + file_handler.file_path, start_offset) + return True except exceptions.CRCFailedError: file_handler.reset_offset(start_offset) logger.warning("Check crc faild and ignore this file, file_path=%s, "